Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #7577 markets: When retrying Add Piece, first seek to start of reader #7812

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Dec 17, 2021

Related Issues

Fixes #7577
Depends on #7646
Includes fixes filecoin-project/go-fil-markets#657 filecoin-project/go-fil-markets#656

Proposed Changes

Change the markets process to ensure that each time it retries add piece, it seeks to the beginning of the data source.

Checklist

Before you mark the PR ready for review, please make sure that:

PR Notes

Note that there are a lot of updates to dependencies because of filecoin-project/go-fil-markets#653

@dirkmc dirkmc changed the title when retrying Add Piece, first seek to start of reader fix: #7577 markets: When retrying Add Piece, first seek to start of reader Dec 17, 2021
@dirkmc dirkmc force-pushed the feat/retry-ap-seek-start branch 3 times, most recently from 3336f38 to c5471d5 Compare December 17, 2021 13:36
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #7812 (6db8a86) into master (a4728d3) will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7812   +/-   ##
=======================================
  Coverage   39.47%   39.48%           
=======================================
  Files         654      654           
  Lines       70033    70036    +3     
=======================================
+ Hits        27649    27656    +7     
+ Misses      37633    37632    -1     
+ Partials     4751     4748    -3     
Impacted Files Coverage Δ
markets/storageadapter/provider.go 41.23% <25.00%> (-0.60%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
chain/vm/mkactor.go 48.48% <0.00%> (-3.04%) ⬇️
paychmgr/simple.go 78.39% <0.00%> (-1.86%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
miner/miner.go 56.95% <0.00%> (-1.33%) ⬇️
extern/storage-sealing/fsm.go 55.77% <0.00%> (-1.20%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4728d3...6db8a86. Read the comment docs.

@jennijuju jennijuju added this to the v1.13.3 milestone Dec 17, 2021
@dirkmc dirkmc marked this pull request as ready for review December 21, 2021 10:23
@dirkmc dirkmc requested a review from a team as a code owner December 21, 2021 10:23
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about the markets update made api/ depend on filecoin-ffi

=== RUN   TestDoesntDependOnFFI
    api_test.go:35: api depends on filecoin-ffi
--- FAIL: TestDoesntDependOnFFI (1.26s)

@magik6k magik6k merged commit c755cee into master Dec 21, 2021
@magik6k magik6k deleted the feat/retry-ap-seek-start branch December 21, 2021 17:06
@jennijuju jennijuju modified the milestones: v1.13.3, v1.15.0 Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart the lotus market subsystem will mess up the raw data
3 participants