-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #7577 markets: When retrying Add Piece, first seek to start of reader #7812
Conversation
4d84d81
to
eb9356d
Compare
3336f38
to
c5471d5
Compare
c5471d5
to
839fc8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #7812 +/- ##
=======================================
Coverage 39.47% 39.48%
=======================================
Files 654 654
Lines 70033 70036 +3
=======================================
+ Hits 27649 27656 +7
+ Misses 37633 37632 -1
+ Partials 4751 4748 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something about the markets update made api/
depend on filecoin-ffi
=== RUN TestDoesntDependOnFFI
api_test.go:35: api depends on filecoin-ffi
--- FAIL: TestDoesntDependOnFFI (1.26s)
Related Issues
Fixes #7577
Depends on #7646
Includes fixes filecoin-project/go-fil-markets#657 filecoin-project/go-fil-markets#656
Proposed Changes
Change the markets process to ensure that each time it retries add piece, it seeks to the beginning of the data source.
Checklist
Before you mark the PR ready for review, please make sure that:
Note: Tests are in add SeekStart method to inflator reader go-fil-markets#656
PR Notes
Note that there are a lot of updates to dependencies because of filecoin-project/go-fil-markets#653