Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: builder: env var for managing rcmgr #8282

Closed
wants to merge 2 commits into from
Closed

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 10, 2022

Also disable it by default for now, until we can figure out what's broken (also disabling by default means that people will not set the envvar to disable rcmgr and keep it after we've fixed issues)

@magik6k magik6k requested a review from a team as a code owner March 10, 2022 10:20
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #8282 (557c381) into master (326a9b6) will increase coverage by 5.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8282      +/-   ##
==========================================
+ Coverage   34.91%   40.47%   +5.55%     
==========================================
  Files         670      675       +5     
  Lines       73299    73527     +228     
==========================================
+ Hits        25595    29758    +4163     
+ Misses      42896    38544    -4352     
- Partials     4808     5225     +417     
Impacted Files Coverage Δ
node/builder.go 76.47% <ø> (ø)
storage/wdpost_sched.go 75.49% <0.00%> (-5.89%) ⬇️
chain/exchange/client.go 49.15% <0.00%> (-4.67%) ⬇️
miner/miner.go 56.39% <0.00%> (-1.64%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-1.50%) ⬇️
extern/sector-storage/sched.go 84.77% <0.00%> (-0.83%) ⬇️
itests/kit/blockminer.go 69.61% <0.00%> (-0.56%) ⬇️
chain/actors/builtin/miner/v7.go 52.90% <0.00%> (-0.31%) ⬇️
markets/dagstore/mocks/mock_lotus_accessor.go 80.48% <0.00%> (ø)
lib/nullreader/reader.go 0.00% <0.00%> (ø)
... and 140 more

Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that wont disable it but rather use the default.

You need to pass network.NullResourceManager to disable it.

@jennijuju
Copy link
Member

@vyzo lmao request change!!! thank you for reviewing 🟦

@vyzo
Copy link
Contributor

vyzo commented Mar 15, 2022

#8318 does it properly.

@vyzo vyzo closed this Mar 15, 2022
@vyzo vyzo deleted the feat/rcmgr-env branch March 15, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants