Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make BitField::new const #850

Merged
merged 1 commit into from
Jun 30, 2023
Merged

feat: make BitField::new const #850

merged 1 commit into from
Jun 30, 2023

Conversation

Stebalien
Copy link
Member

This won't actually improve performance, but may help with some ergonomics.

@Stebalien Stebalien requested a review from mriise September 8, 2022 04:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #850 (9af4004) into master (3ad5b90) will decrease coverage by 6.19%.
The diff coverage is 100.00%.

❗ Current head 9af4004 differs from pull request most recent head 0ae2f43. Consider uploading reports for the commit 0ae2f43 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
- Coverage   74.97%   68.78%   -6.19%     
==========================================
  Files         148      149       +1     
  Lines       14281    16758    +2477     
==========================================
+ Hits        10707    11527     +820     
- Misses       3574     5231    +1657     
Impacted Files Coverage Δ
ipld/bitfield/src/lib.rs 78.53% <100.00%> (+0.45%) ⬆️

... and 88 files with indirect coverage changes

@Stebalien Stebalien closed this Sep 8, 2022
@Stebalien
Copy link
Member Author

Guess that isn't stable yet.

@Stebalien Stebalien deleted the feat/const-bitfield branch September 8, 2022 05:09
@mriise
Copy link
Contributor

mriise commented Sep 12, 2022

for posterity, rustlang tracking issue for this: rust-lang/rust#71835

This won't actually improve performance, but may help with some
ergonomics.
@Stebalien Stebalien restored the feat/const-bitfield branch June 29, 2023 23:59
@Stebalien Stebalien reopened this Jun 30, 2023
@Stebalien Stebalien force-pushed the feat/const-bitfield branch from 9af4004 to 0ae2f43 Compare June 30, 2023 00:00
@Stebalien Stebalien requested review from fridrik01 and removed request for mriise June 30, 2023 00:07
@Stebalien Stebalien enabled auto-merge (squash) June 30, 2023 00:07
@Stebalien
Copy link
Member Author

cleaning up old branches...

@Stebalien Stebalien merged commit 2138878 into master Jun 30, 2023
@Stebalien Stebalien deleted the feat/const-bitfield branch June 30, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants