Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #4759 venus-wallet : add docker feature #82

Closed
wants to merge 4 commits into from
Closed

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented May 11, 2022

Related Issues

filecoin-project/venus#4759

Proposed Changes

add docker features
add github action for automaticly pushing to dockerhub

Additional Info

Checklist
Before you mark the PR ready for review, please make sure that:

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #82 (ba2b0cc) into main (8050f86) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   12.73%   12.73%           
=======================================
  Files          48       48           
  Lines        4121     4121           
=======================================
  Hits          525      525           
  Misses       3505     3505           
  Partials       91       91           
Flag Coverage Δ
unittests 12.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了和venus-miner相同外,因venus-wallet的主分支变更为master,这个需要重新提交

@diwufeiwen diwufeiwen deleted the branch main June 7, 2022 02:52
@diwufeiwen diwufeiwen closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants