Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #4759 venus-wallet : add docker feature #84

Merged
merged 10 commits into from
Jun 10, 2022
Merged

feat: #4759 venus-wallet : add docker feature #84

merged 10 commits into from
Jun 10, 2022

Conversation

LinZexiao
Copy link
Collaborator

Related Issues

filecoin-project/venus#4759

Proposed Changes

add docker features
add github action for automaticly pushing to dockerhub

@LinZexiao LinZexiao requested a review from diwufeiwen June 8, 2022 06:41
@codecov-commenter
Copy link

Codecov Report

Merging #84 (337cf30) into master (8050f86) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   12.73%   12.73%           
=======================================
  Files          48       48           
  Lines        4121     4121           
=======================================
  Hits          525      525           
  Misses       3505     3505           
  Partials       91       91           
Flag Coverage Δ
unittests 12.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
建议: (1) commit message风格统一,如 feat: *** 与 feat:***;(2)如果想关联关闭venus issue,需要加fix或resolve等关键字

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants