-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #4759 venus-wallet : add docker feature #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 12.73% 12.73%
=======================================
Files 48 48
Lines 4121 4121
=======================================
Hits 525 525
Misses 3505 3505
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. |
diwufeiwen
reviewed
Jun 9, 2022
diwufeiwen
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
建议: (1) commit message风格统一,如 feat: *** 与 feat:***;(2)如果想关联关闭venus issue,需要加fix或resolve
等关键字
* upgrade venus * add `version` protocol into multiaddr twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/venus#4759
Proposed Changes
add docker features
add github action for automaticly pushing to dockerhub