Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] v0.0.4 of dht code can panic go-filecoin should update to more recent version #2752

Closed
frrist opened this issue May 9, 2019 · 1 comment
Labels
C-bug Category: This is a bug P0 Fire Drill - drop what you are doing, devnet panic or similar

Comments

@frrist
Copy link
Member

frrist commented May 9, 2019

Describe the bug
go-filecoin node panicked:

panic: counter already signaled done. use a new counter.

goroutine 38178114 [running]:
github.com/ipfs/go-todocounter.(*todoCounter).Increment(0xc0a7475ce0, 0xc000000001)
        /home/frrist/pkg/mod/github.com/ipfs/go-todocounter@v0.0.1/counter.go:86 +0xaf
github.com/libp2p/go-libp2p-kad-dht.(*dhtQueryRunner).addPeerToQuery(0xc08e864e70, 0xc0231dcc00, 0x22)
        /home/frrist/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/query.go:200 +0x103
github.com/libp2p/go-libp2p-kad-dht.(*dhtQueryRunner).Run(0xc08e864e70, 0x19402c0, 0xc0957503c0, 0xc0a7475590, 0x3, 0x3, 0x0, 0x0, 0x0)
        /home/frrist/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/query.go:136 +0x140
github.com/libp2p/go-libp2p-kad-dht.(*dhtQuery).Run(0xc0a7475620, 0x19402c0, 0xc0957503c0, 0xc0a7475590, 0x3, 0x3, 0x0, 0x0, 0x0)
        /home/frrist/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/query.go:70 +0xff
github.com/libp2p/go-libp2p-kad-dht.(*IpfsDHT).GetClosestPeers.func2(0xc077359380, 0xc093c37c20, 0xc0a7475620, 0x1940340, 0xc077359320, 0xc0a7475590, 0x3, 0x3, 0xc08dc42900, 0x26)
        /home/frrist/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/lookup.go:96 +0xdb
created by github.com/libp2p/go-libp2p-kad-dht.(*IpfsDHT).GetClosestPeers
        /home/frrist/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/lookup.go:92 +0x358

To Reproduce
Happens non-deterministically, running node for sometime should surface panic.

Expected behavior
Node does not panic.

Diagnostic information

  • Filecoin Inspect Output:
  "Disk": {
    "FSType": "61267",
    "Free": 412155428864,
    "Total": 387160211456
  },
  "Environment": {
    "FIL_API": "",
    "FIL_PATH": "/home/frrist/filecoin0",
    "GOPATH": "/home/frrist"
  },
  "FilecoinVersion": "d7c3b1df109b7d3e119302a02ba956ab75fa2bb2",
  "Memory": {
    "Swap": 0,
    "Virtual": 13021308000
  },
  "Runtime": {
    "Arch": "amd64",
    "Compiler": "gc",
    "GoMaxProcs": 8,
    "NumCGoCalls": 767,
    "NumGoRoutines": 547,
    "NumProc": 8,
    "OS": "linux",
    "Version": "go1.12.1"
  }
}
  • Current Head: zDPWYqFD5cJX3tbcxDw7dkc4ZkxRexN7Gc8oCRCdfArj7tLWC1bG

Additional context
The panic in the dht was addressed here: libp2p/go-libp2p-kad-dht#292
go-filecoin should use a version of dht with said fix.

@frrist frrist added C-bug Category: This is a bug P0 Fire Drill - drop what you are doing, devnet panic or similar labels May 9, 2019
@frrist
Copy link
Member Author

frrist commented May 9, 2019

dup of #2753.

@frrist frrist closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug P0 Fire Drill - drop what you are doing, devnet panic or similar
Projects
None yet
Development

No branches or pull requests

1 participant