Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Panic in dht for user devnet 0.2.1 #2753

Closed
travisperson opened this issue May 9, 2019 · 0 comments · Fixed by #2754
Closed

[bug] Panic in dht for user devnet 0.2.1 #2753

travisperson opened this issue May 9, 2019 · 0 comments · Fixed by #2754
Assignees
Labels
C-bug Category: This is a bug P0 Fire Drill - drop what you are doing, devnet panic or similar

Comments

@travisperson
Copy link
Contributor

Got this panic a few times now on my nodes running 0.2.1 and @frrist has seen it as well

panic: counter already signaled done. use a new counter.

goroutine 16680219 [running]:
github.com/ipfs/go-todocounter.(*todoCounter).Increment(0xc056d4eae0, 0xc000000001)
        /home/ubuntu/pkg/mod/github.com/ipfs/go-todocounter@v0.0.1/counter.go:86 +0xaf
github.com/libp2p/go-libp2p-kad-dht.(*dhtQueryRunner).addPeerToQuery(0xc06ff17340, 0xc012deda40, 0x22)                                                                                     
        /home/ubuntu/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/query.go:200 +0x103
github.com/libp2p/go-libp2p-kad-dht.(*dhtQueryRunner).Run(0xc06ff17340, 0x1940bc0, 0xc073a03200, 0xc050a73650, 0x3, 0x3, 0x0, 0x0, 0x0)                                                    
        /home/ubuntu/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/query.go:136 +0x140
github.com/libp2p/go-libp2p-kad-dht.(*dhtQuery).Run(0xc050a736e0, 0x1940bc0, 0xc073a03200, 0xc050a73650, 0x3, 0x3, 0x0, 0x0, 0x0)                                                            
        /home/ubuntu/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/query.go:70 +0xff
github.com/libp2p/go-libp2p-kad-dht.(*IpfsDHT).GetClosestPeers.func2(0xc07c088900, 0xc061d0d120, 0xc050a736e0, 0x1940c40, 0xc07d541980, 0xc050a73650, 0x3, 0x3, 0xc0437d37d0, 0x26)          
        /home/ubuntu/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/lookup.go:96 +0xdb
created by github.com/libp2p/go-libp2p-kad-dht.(*IpfsDHT).GetClosestPeers
        /home/ubuntu/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.0.4/lookup.go:92 +0x358

Related libp2p issue: libp2p/go-libp2p-kad-dht#292

We are currently on 0.0.4 of go-libp2p-kad-dht and we need to be on at least 0.0.5 (fixed in libp2p/go-libp2p-kad-dht#301)

https://github.com/filecoin-project/go-filecoin/blob/d7c3b1df109b7d3e119302a02ba956ab75fa2bb2/go.mod#L51

@travisperson travisperson added the C-bug Category: This is a bug label May 9, 2019
@frrist frrist added the P0 Fire Drill - drop what you are doing, devnet panic or similar label May 9, 2019
frrist added a commit that referenced this issue May 9, 2019
@frrist frrist self-assigned this May 9, 2019
acruikshank pushed a commit that referenced this issue May 9, 2019
acruikshank pushed a commit that referenced this issue May 9, 2019
frrist added a commit that referenced this issue May 10, 2019
update to go-libp2p-kad-dht@v0.0.8
  - fixes #2753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug P0 Fire Drill - drop what you are doing, devnet panic or similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants