-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/better inspect output 2720 #2730
Conversation
db441db
to
bc1f2ab
Compare
I don't think the text encoder should be outputting json. I would prefer it output a table, or even just plain text. Here are some examples of what I am thinking:
or
If a user wants the output of a command to be pretty printed they can achieve this using
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the changes I have described in my previous comment.
bc1f2ab
to
403609d
Compare
@frrist Comments addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one blocking comment, then lgtm
08a7645
to
0ab24fc
Compare
0ab24fc
to
867bcc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
The output from the inspect commands are difficult to read by default.
Solution
Use pretty-printed json for text output, and maintain compact json for use with the
--enc=json
flag.Resolves #2720