Allow setting path to binary under test #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisperson
force-pushed
the
feat/allow-setting-binary-under-test
branch
from
b9c5908
to
1f421fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #3410 +/- ##
======================================
- Coverage 46% 46% -1%
======================================
Files 241 241
Lines 15602 15604 +2
======================================
- Hits 7262 7196 -66
- Misses 7294 7369 +75
+ Partials 1046 1039 -7 |
anorth
reviewed
Sep 12, 2019
testhelpers/util.go
Outdated
| return "", err | ||
| } | ||
|
|
||
| bin = filepath.Join(gopath, "/src/github.com/filecoin-project/go-filecoin/go-filecoin") |
There was a problem hiding this comment.
I think we should delete the fallback to GOPATH, but instead expect "./go-filecoin". Yes, this requires the right CWD, but the binary-path option supports other cases.
frrist
approved these changes
Sep 12, 2019
frrist
approved these changes
Sep 12, 2019
anorth
approved these changes
Oct 8, 2019
travisperson
force-pushed
the
feat/allow-setting-binary-under-test
branch
from
44d1f9d
to
69bdfa9
Compare
travisperson
force-pushed
the
feat/allow-setting-binary-under-test
branch
from
69bdfa9
to
1824b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable running the network deployment tests during network setup we can build the tests as an executable binary using the
-cflag ofgo test. Currently all of our tests are forced into using a binary located at the project root. This flags allows overriding the binary that will be used for tests which forkgo-filecoin.