update go-fil-markets + implement a shared GetChainHead #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3880 +/- ##
========================================
- Coverage 39% 25% -15%
========================================
Files 233 152 -81
Lines 13775 8352 -5423
========================================
- Hits 5478 2117 -3361
+ Misses 7504 5916 -1588
+ Partials 793 319 -474 |
anorth
approved these changes
Mar 17, 2020
factor GetChainHead into shareable function move into connectors dir move market and storage node-connectors into new connectors dir change panic reorder imports change relative path to accommodate new structure obey linter
laser
force-pushed
the
chores/go-fil-get-chain-head
branch
from
6d882d8
to
e11f53e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes incremental progress towards this go-fil-markets issue.
Motivation
All chain-querying methods need to be provided a tipset identifier. This will allow
Node*consumers to issue multiple queries against the same chain state (i.e. the chain's state won't change out from underneath them as the chain's head changes).Proposed changes
This PR updates go-fil-markets to a version in which the node is expected to provide a
GetChainHeadmethod and provides implementations for various connector structs.