Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change init logic #5941

Merged
merged 1 commit into from
May 4, 2023
Merged

feat: change init logic #5941

merged 1 commit into from
May 4, 2023

Conversation

hunjixin
Copy link
Contributor

关联的Issues (Related Issues)

close #5940

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@hunjixin hunjixin self-assigned this Apr 27, 2023
@hunjixin hunjixin force-pushed the feat/change_init_logic branch 3 times, most recently from 13a00a7 to 0f801b0 Compare April 28, 2023 02:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #5941 (648202b) into master (ad3d0c6) will increase coverage by 0%.
The diff coverage is 51%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5941   +/-   ##
======================================
  Coverage      24%     24%           
======================================
  Files         656     656           
  Lines       79781   79768   -13     
======================================
+ Hits        19554   19562    +8     
+ Misses      57636   57621   -15     
+ Partials     2591    2585    -6     

@hunjixin hunjixin force-pushed the feat/change_init_logic branch 2 times, most recently from cca192a to cc52aa4 Compare April 28, 2023 07:01
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 5831990 into master May 4, 2023
@simlecode simlecode deleted the feat/change_init_logic branch May 4, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus] change venus init logic / 修改venus启动逻辑
3 participants