Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[venus] add design doc of sync/添加同步设计文档 #5989

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

elvin-du
Copy link
Collaborator

@elvin-du elvin-du commented May 25, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@elvin-du elvin-du self-assigned this May 25, 2023
@elvin-du elvin-du added the C-docs Category: Documentation label May 25, 2023
@elvin-du elvin-du requested a review from diwufeiwen May 25, 2023 06:46
@codecov-commenter
Copy link

Codecov Report

Merging #5989 (6b93430) into master (cbae30f) will decrease coverage by 1%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5989   +/-   ##
======================================
- Coverage      24%     24%   -1%     
======================================
  Files         657     657           
  Lines       79760   79760           
======================================
- Hits        19583   19576    -7     
- Misses      57587   57594    +7     
  Partials     2590    2590           

@elvin-du elvin-du requested review from simlecode and LinZexiao and removed request for diwufeiwen July 6, 2023 08:33
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit a885fc4 into master Aug 15, 2023
@simlecode simlecode deleted the docs/elvivdu/add-venus-sync branch August 15, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs Category: Documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants