Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Network parameters add an Eip155ChainID field #5997

Merged
merged 1 commit into from
May 31, 2023

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented May 30, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen self-assigned this May 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #5997 (25f753a) into master (7569018) will decrease coverage by 1%.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5997   +/-   ##
======================================
- Coverage      24%     24%   -1%     
======================================
  Files         657     657           
  Lines       79754   79755    +1     
======================================
- Hits        19586   19566   -20     
- Misses      57580   57596   +16     
- Partials     2588    2593    +5     

@diwufeiwen diwufeiwen force-pushed the feat/lt/add_Eip155ChainID_field_in_network_params branch from 198ca29 to 25f753a Compare May 31, 2023 01:54
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 12121f1 into master May 31, 2023
@simlecode simlecode deleted the feat/lt/add_Eip155ChainID_field_in_network_params branch May 31, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants