Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(market): filter deals by sector lifetime #6093

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

0x5459
Copy link
Collaborator

@0x5459 0x5459 commented Aug 11, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

根据扇区的生命周期过滤订单,用于 snapdeal

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

LinZexiao
LinZexiao previously approved these changes Aug 11, 2023
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5459 0x5459 force-pushed the feat/0x5459/market-filter-deals branch from bab92e1 to d34b918 Compare August 11, 2023 02:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #6093 (e471284) into master (20ffb74) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6093   +/-   ##
======================================
  Coverage      24%     24%           
======================================
  Files         662     662           
  Lines       80366   80366           
======================================
+ Hits        19691   19696    +5     
+ Misses      58066   58063    -3     
+ Partials     2609    2607    -2     

@0x5459 0x5459 changed the base branch from master to release/v1.12 August 11, 2023 03:02
@0x5459 0x5459 closed this Aug 11, 2023
@0x5459 0x5459 deleted the feat/0x5459/market-filter-deals branch August 11, 2023 03:05
@0x5459 0x5459 restored the feat/0x5459/market-filter-deals branch August 11, 2023 03:11
@0x5459 0x5459 reopened this Aug 11, 2023
@0x5459 0x5459 changed the base branch from release/v1.12 to master August 11, 2023 03:12
@0x5459 0x5459 mentioned this pull request Aug 11, 2023
6 tasks
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit e757b70 into master Aug 15, 2023
2 checks passed
@simlecode simlecode deleted the feat/0x5459/market-filter-deals branch August 15, 2023 01:34
simlecode added a commit that referenced this pull request Aug 15, 2023
…-release-v1.12

Cherry pick #6093 to release v1.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants