-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(market): filter deals by sector lifetime #6093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinZexiao
previously approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0x5459
force-pushed
the
feat/0x5459/market-filter-deals
branch
from
August 11, 2023 02:10
c099bc4
to
bab92e1
Compare
0x5459
force-pushed
the
feat/0x5459/market-filter-deals
branch
from
August 11, 2023 02:20
bab92e1
to
d34b918
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6093 +/- ##
======================================
Coverage 24% 24%
======================================
Files 662 662
Lines 80366 80366
======================================
+ Hits 19691 19696 +5
+ Misses 58066 58063 -3
+ Partials 2609 2607 -2 |
6 tasks
simlecode
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
simlecode
added a commit
that referenced
this pull request
Aug 15, 2023
…-release-v1.12 Cherry pick #6093 to release v1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
close
改动 (Proposed Changes)
根据扇区的生命周期过滤订单,用于 snapdeal
附注 (Additional Info)
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that: