Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: assert stationId at 88 bytes instead of 64 #257

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix: assert stationId at 88 bytes instead of 64 #257

merged 1 commit into from
Apr 25, 2024

Conversation

PatrickNercessian
Copy link
Contributor

@PatrickNercessian PatrickNercessian commented Apr 25, 2024 •
edited
Loading

Follow up for #249

@PatrickNercessian
Copy link
Contributor Author

Link: space-meridian/roadmap#97

bajtos
bajtos approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@bajtos bajtos merged commit 738ce19 into filecoin-station:main Apr 25, 2024
8 checks passed
@bajtos
Copy link
Member

bajtos commented Apr 25, 2024

This change is because an ED25519 public key exported in the SPKI format always has 44 bytes, which is 88 characters in hexadecimal encoding. (The SPKI format starts with a 6-byte prefix identifying the algorithm used.)

See also:

@bajtos bajtos mentioned this pull request Apr 25, 2024
Merged
@PatrickNercessian PatrickNercessian deleted the station-id-fix branch July 1, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Space Meridian
Status: ✅ done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickNercessian @bajtos