Add publish rsr to smart contract #383
Conversation
juliangruber
commented
Oct 20, 2024
•
juliangruber
commented
- Deploy rsr contract to mainnet
- Publish rsr
- Publish own git hash
- Write tests
- Create Storacha space
- Configure Storacha environment variables
- Update schema
- Publish as IPLD
- Publish round details to Storacha
- Dynamically split CAR into multiple blocks (should not be blocking release)
| ARG GIT_COMMIT | ||
| ENV GIT_COMMIT=$GIT_COMMIT |
There was a problem hiding this comment.
Should we document this new required argument for the situations when we want to run docker build locally?
There was a problem hiding this comment.
I never run docker build locally, what is the use case for that?
There was a problem hiding this comment.
I usually build locally when troubleshooting docker build failures on the CI or when making changes to the Dockerfile. It's faster to do this locally than wait for the CI run.
It's not a big deal for me if you don't document this.
There was a problem hiding this comment.
Got it! I'm happy to document it, where's a good place for that?
migrations/020.do.publish-rsr.sql
Outdated
| spark_evaluate_version TEXT NOT NULL, | ||
| measurement_commitments TEXT[] NOT NULL, | ||
| round_details JSONB NOT NULL, | ||
| providers JSONB NOT NULL |
There was a problem hiding this comment.
I find the name providers as too ambiguous/potentially confusing, since this does not store a list of providers, but a list of per-provider retrieval stats.
The smart-contract uses the name providerRetrievalResultStats, which I find too long and redundant in the scope of unpublished_rsr_rounds.
How about this?
| providers JSONB NOT NULL | |
| providers_stats JSONB NOT NULL |
Not a big deal, we can keep the current name if you prefer. It's an internal implementation detail that can be easily changed later.
There was a problem hiding this comment.
I have renamed to provider_retrieval_result_stats, to match the contract. What part of it is redundant in the scope of unpublished_rsr_round?
Co-authored-by: Miroslav Bajtoš <oss@bajtos.net>
|
@bajtos hindsight please |
