ci: make release builds agnostic of runner version #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
force-pushed
the
fix-release-builds
branch
2 times, most recently
from
58b33d5 to
8a0f83a
Compare
Rework all `if` conditions in workflow steps from checking the exact string equality (e.g. `matrix.os == 'macos-latest'`) to checking only the platform prefix (e.g. `startsWith(matrix.os, 'macos-')`). This fixes the regression introduced by eb98870 (#490). Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
force-pushed
the
fix-release-builds
branch
from
8a0f83a to
7628eea
Compare
|
All platforms were built correctly with my changes in place: |
|
Oops, I thought Zinnia required approval before auto-merge kicked in. @juliangruber, could you please review my PR for any hindsight? 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework all
ifconditions in workflow steps from checking the exact string equality (e.g.matrix.os == 'macos-latest') to checking only the platform prefix (e.g.startsWith(matrix.os, 'macos-')).This fixes the regression introduced by eb98870 (#490), see https://github.com/filecoin-station/zinnia/actions/runs/8718338987