Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MachLinkEditData: Implement .ToString(), keep track of parents #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qmfrederik
Copy link
Collaborator

Make debugging a bit easier by:

  • Keeping track of the parent of MachLinkEditData objects
  • Implement a .ToString() which returns the start and end of the range, as well as the length

Make debugging a bit easier by:
- Keeping track of the parent of `MachLinkEditData` objects
- Implement a `.ToString()` which returns the start and end of the range, as well as the length
@filipnavara
Copy link
Owner

(Sorry for delayed response. Unfortunately I will have very limited internet access until tomorrow evening, and then I will have to deal with couple of medical issues as I return back to Prague. I will try to review remaining PRs until the end of the week.)

I tried to avoid the back-/parent links in the design to avoid some object cycles. It looks like with the current design it would not cause any cycles that could result in high memory usage but I will need to take another look at it to see if it can be done in a way that prevents any programming error or stray references.

@qmfrederik
Copy link
Collaborator Author

@filipnavara No worries, I was also travelling this week. I understand the concern about back references. This was mainly for debugging purposes; I think it's fine if you decide not to take the back references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants