Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to install system integration: Failed to process and store site icon: Failed to load icon: The image format could not be determined #69

Closed
adrianiepure opened this issue Oct 28, 2021 · 2 comments
Closed

Failed to install system integration: Failed to process and store site icon: Failed to load icon: The image format could not be determined #69

adrianiepure opened this issue Oct 28, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@adrianiepure
Copy link

Description

When trying to create a new site, I get the following error:

'Failed to install system integration: Failed to process and store site icon: Failed to load icon: The image format could not be determined'

image

Please help find a solution :)

Steps to Reproduce

  1. Go to 'https://mingle-cloudidentities.eu1.inforcloudsuite.com/idp/SSO.saml2'
  2. Go to 'Install current site'
  3. Click on 'Install web app'
  4. See error

Additional Information

It works on other websites.

Affected Websites

Environment

  • Operating system: Windows 10
  • System architecture: x64
  • FirefoxPWA extension version: 1.2.0
  • FirefoxPWA native version: 1.2.0
  • Firefox version: 93.0 (64-bit)
@adrianiepure adrianiepure added the bug Something isn't working label Oct 28, 2021
filips123 added a commit that referenced this issue Oct 29, 2021
@filips123
Fix page info collection in the content script (#69)
ee2b831 
* Use document base URL instead of current location
* Fix wrong condition in Apple mask icon detection
filips123 added a commit that referenced this issue Oct 29, 2021
@filips123
Improve icon loading to generate fallback icon if needed (#69)
f0cd6e4 
Details:
* This changes site loading/storing process to generate fallback icon from the site name when something is wrong with the site icon.
* It should allow user to install sites that may have broken icons.
* It does not apply to macOS yet.

Plans:
* In the future, `store_icon`/`store_icons` functions should be improved to fall back to the next available icon, and only generate icon if no icons work.
* This should also apply to macOS.
@filips123
Copy link
Owner

Because of this report, I actually discovered four bugs/problems with the program... Anyway, these problems should be fixed or at least have a workaround in v1.2.1.

The remaining problem is that Infor favicon uses some format that is currently not compatible with the image crate. Because of this, you won't get the correct icon when installing the site, but auto-generated icon with the letter "I" (from the site name). I don't know when this will be fixed, as it depends on the image crate.

In the future, I also plan to improve the function for processing icons and make fallback better, but I will create another issue for that.

@adrianiepure
Copy link
Author

Thanks for the quick fix @filips123. I can now install the site without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filips123 @adrianiepure