Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FINDO-8282_apply_psr_12 #103

Merged
merged 2 commits into from
Dec 16, 2019
Merged

FINDO-8282_apply_psr_12 #103

merged 2 commits into from
Dec 16, 2019

Conversation

howard
Copy link
Collaborator

@howard howard commented Aug 20, 2019 •
edited by TheKeymaster
Loading

Purpose

Following the approval of PSR 12, bring the code base to match those guidelines.

Approach

Add PSR 12 lint rule and fix violations.

Open Questions and Pre-Merge TODOs

  • composer lint and composer fix was executed.
  • Tests were written and pass with 100% coverage.
  • A issue with a detailed explanation of the problem/enhancement was created and linked. No need for a separate issue.

@howard howard self-assigned this Aug 20, 2019
TheKeymaster
TheKeymaster approved these changes Aug 20, 2019
View reviewed changes
Copy link

@TheKeymaster TheKeymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked the last checkbox since there was nothing to do.
  • Code LGTM.
  • Nice that we are now on PSR-12.

@howard howard merged commit c0a2bc5 into develop Dec 16, 2019
@howard howard deleted the FINDO-8282_apply_psr_12 branch December 16, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheKeymaster TheKeymaster TheKeymaster approved these changes

Assignees

@howard howard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard @TheKeymaster