Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simulator): Update simulator to alert if the event name is bad #164

Merged
merged 1 commit into from
May 23, 2024

Conversation

finger563
Copy link
Owner

Description

Add alert to simulator so that if the user enters an event name that is invalid (but not empty), it alerts them that it is invalid.

Motivation and Context

Related to #163 we'd like to know when we make the event that the name is valid / invalid. similarly, if we open a model or edit a model, we'd like to be alerted if there are bad event names already present in the model.

How has this been tested?

Opening a good model, adding a bad even name, seeing the error. Also validated that the alert shows when opening a model if the model has a bad even name in it. Of course also tested with multiple bad event names (therefore multiple alerts).

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Event name marked in red (existing behavior): showing that it is invalid:
CleanShot 2024-05-23 at 09 38 38

And alert when saving it:
CleanShot 2024-05-23 at 09 38 31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this May 23, 2024
@finger563 finger563 merged commit d7e9c15 into main May 23, 2024
@finger563 finger563 deleted the feature/simulator-alert-bad-event-name branch May 23, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant