Simplify snakemake #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking advantage of some snakemake features to reduce redundancy.
fingerfen
approved these changes
Dec 16, 2019
|
@jashapiro I just merged and made a tiny change to the "rule_all" of the Snakemake file to accommodate your changes. I tested it and it generated the outputs fine. Thank you for the edits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fingerfen:
I started to review your latest PR, and realized that we could take advantage of some snakemake features to simplify and remove redundancy. What I have done here is use wildcards to make each of the filter-telomeres jobs just take a single bed file and filter it, since all of them use the same script and only change options a bit. The extra wildcards are constrained to make sure they don't do anything funny with regex matching. It seems to work for me, but do check that it is still performing the functions you expect!