License change to MIT License (closes #118) #127
Conversation
There was a problem hiding this comment.
Very nicely done. Your attention to deal was superb. Take a look at my comments and let me know your feed back. Unless there are some conventions I am not following or something, those have been my experiences with copyrights. I need to check the copyright one last time. Overall well done.
| @@ -17,6 +12,27 @@ Gnd (Ground) -> Gnd | |||
| SDA (Serial Data) -> A4 on Uno/Pro-Mini, 20 on Mega2560/Due, 2 Leonardo/Pro-Micro | |||
| SCK (Serial Clock) -> A5 on Uno/Pro-Mini, 21 on Mega2560/Due, 3 Leonardo/Pro-Micro | |||
|
|
|||
|
|
|||
| Copyright (c) 2015-2021 Tyler Glenn, et al. | |||
There was a problem hiding this comment.
I think we should keep the original year only. We can have a modified date if it is needed to keep dates for newer files or major revisions. Having 2015-2021 will always be something that needs updating.
| @@ -24,6 +15,27 @@ Gnd (Ground) -> Gnd | |||
| SDA (Serial Data) -> D2 on ESP8266 | |||
| SCK (Serial Clock) -> D1 on ESP8266 | |||
|
|
|||
|
|
|||
| Copyright (c) 2015-2021 Tyler Glenn, Alex Shavlovsky, et al. | |||
There was a problem hiding this comment.
To be honest I think I would just like to have the date the original file was written. I don’t really see a need for it to be updated. The copyright really only shows who wrote this code first, so the initial date is really the only one that matters. The github history can show the rest…. Unless someone can provide a valid argument against it….
There was a problem hiding this comment.
Hey @finitespace,
Sorry for the delay.
I have changed the copyright dates for the merge request according to your comments.
Wherever there was a copyright stated in the files I used that even if the created date in the comment statet the previous year.
However, in one case where the copyright statement claimed 2016 but the file was create 2017 (as stated in the comment inside the file), I took the more recent year.
I am not a lawywer and definitely not a copyright expert. I presume that the stated year refers to the time of release, not the time the file was initially created.
That would explain the cases where, e.g., files were created 2015 but the copyright statement states 2016.
Cheers, @tinxx
|
Hey @finitespace, how's it goin? Do you think you could find time to look into the changes? |
|
Hey @finitespace, this is a kind reminder of this open PR =) |
This PR changes the license to MIT License (ref. #118).