Corr branch #20
Merged
Corr branch #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed version number to avoid Arduino complaining about “Invalid version found: 2.1.02”
Compiler warning: integer overflow in expression. Changed 100*1000 to 100000.0
Changed default mode value to 0x1 (forced mode), to be consistent with the comments in Arduino source file examples.
The example BME280I2C constructor values were wrong, correct order is tosr, hosr, posr and not posr, tosr, hosr. Also corrected the mode value to 3 were normal mode should be selected (according to comments).
Modified code so that when in forced mode the BME280 goes from sleep to forced mode just before reading the data. Original code had a bug, where the sensor was left in sleep mode and it was just reading the old stored measurements in the registers.
Changed the BME280::press method to BME280::pres to be consistent with the README.md
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some small corrections.
Corrected a bug, where reading in forced mode would not perform a new measurement, but just read the old stored data in the registers.