Add support for IBM Cloud Billing Converter #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ibm to progress readme Signed-off-by: Chris Waddington <104161708+chrisw-ibm@users.noreply.github.com>
chrisw-ibm
force-pushed
the
add-ibm-cloud-billing-converter
branch
from
e31a092
to
aaac6b2
Compare
|
@chrisw-ibm thank you this is great. I approved run, it's builing as soon as done I can merge it back. |
|
@varunmittal91 I pushed the fix for the linting error on the import order. Can you approve the run again :) |
Signed-off-by: Chris Waddington <104161708+chrisw-ibm@users.noreply.github.com>
chrisw-ibm
force-pushed
the
add-ibm-cloud-billing-converter
branch
from
5452a07
to
23f1972
Compare
|
@chrisw-ibm sorry for the back and forth |
Signed-off-by: Chris Waddington <104161708+chrisw-ibm@users.noreply.github.com>
|
Thanks for the patch. All checks pass now! |
Thank you so much @chrisw-ibm, this is awesome. |
Hey also realized we need to add IBM to supported list of cloud vendors on the README and add the piechart. I would love to connect and discuss more on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for using the converter to map IBM Cloud Billing Report CSV to the FOCUS specification.
An anonymized billing sample has been added for testing purposes
Unit test added for the billing csv
The data_loader was modified to support IBM Cloud's non-standard csv format which contains a header at the top of the CSV. This metadata is duplicated and concatenated to the billing line items.
progress and conversion rules export reports have been added