-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial AppDirectory POCOs. #58
Conversation
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 88.47% 83.02% -5.45%
==========================================
Files 35 47 +12
Lines 295 383 +88
==========================================
+ Hits 261 318 +57
- Misses 34 65 +31
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few unimportant comments to this beautiful PR :)
src/Fdc3.NewtonsoftJson/Serialization/Fdc3AppDetailsConverter.cs
Outdated
Show resolved
Hide resolved
One last thought: shouldn't we make |
No description provided.