Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automatically increment version in package.json on new release #596

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

divinetettey
Copy link
Contributor

This PR attempts to resolve this issue Automatically increment version in package.json on new release 📦 . The PR aims at automating the update off the version in pacakge.json

  1. A new step has been added to extract the version number from the draft release. this version number is then used in subsequent steps to update the package.json
  2. The extracted version number is used to update the package.json,package-lock.json and the docusaurus.config.js
  3. after update the update a commit is pushed back to the repository

Copy link

linux-foundation-easycla bot commented Jun 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 54a7efe
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66633207a7d8a5000830adc6

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 6b86691
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66fd617d02b9890008718bf3

@JamieSlome
Copy link
Member

Thanks for the PR, @divinetettey 👍 Is there anyway we can update the package.json and package-lock.json version before we run the release? i.e. include the latest version number in the actual release itself

@divinetettey
Copy link
Contributor Author

Thanks for the PR, @divinetettey 👍 Is there anyway we can update the package.json and package-lock.json version before we run the release? i.e. include the latest version number in the actual release itself

sure, let me take a look at this

@divinetettey
Copy link
Contributor Author

Thanks for the PR, @divinetettey 👍 Is there anyway we can update the package.json and package-lock.json version before we run the release? i.e. include the latest version number in the actual release itself

sure, let me take a look at this

should this run before/after the release-drafter

@JamieSlome
Copy link
Member

@divinetettey - we want the file bumps to occur before we make the NPM and GitHub releases. This is to ensure that the releases themselves include the correct version number.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (3b6cb6b) to head (6b86691).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome self-requested a review June 18, 2024 13:31
@JamieSlome
Copy link
Member

@divinetettey, the @divinecodes will also need to authorise with EasyCLA to merge this pull request (heads up).

@divinetettey
Copy link
Contributor Author

@divinetettey, the @divinecodes will also need to authorise with EasyCLA to merge this pull request (heads up).

yeah, my gitconfigs got messed and the commit was pushed with my personal account. I am going to squash the commit and push it with @divinetettey

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy from my end. @divinetettey - have you been able to test the update_version step?

@divinetettey
Copy link
Contributor Author

Happy from my end. @divinetettey - have you been able to test the update_version step?

Yes, getting some failures with release-drafter, taking a look

@divinetettey
Copy link
Contributor Author

Happy from my end. @divinetettey - have you been able to test the update_version step?

all good on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants