Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add repository in package.json files #746

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

tsteenbe
Copy link
Contributor

@tsteenbe tsteenbe commented Oct 11, 2024

Add 'repository' field 1 to various package.json to create a link between release artifacts and corresponding code in the project's repository. This helps SBOM tools such as ORT 2 to create better SBOMs and reduces amount of code that needs to scanned and reviewed for license compliance.

Bit of context: I am working on generating high quality SBOM (e.g with licenses clarified till file level) for eventually all FINOS projects so they can be easier adopted and used in high compliance environments where SBOMs are or will be a "must-have". Don't want to burden maintainers with what's a FOSS consumer topic imo so when I see things causing SBOM issue you will see me shoot in PR to try to fix them.

Add 'repository' field [1] to various package.json to create a link
between release artifacts and corresponding code in the project's repository.
This helps SBOM tools such as ORT [2] to create better SBOMs and reduces
amount of code that needs to scanned and reviewed for license compliance.

[1]: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#repository
[2]: https://github.com/oss-review-toolkit/ort

Signed-off-by: Thomas Steenbergen <opensource@steenbe.nl>
Copy link

linux-foundation-easycla bot commented Oct 11, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit db726af
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/67095320df13a3000889715c
😎 Deploy Preview https://deploy-preview-746--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.34%. Comparing base (c84c100) to head (db726af).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   57.34%   57.34%           
=======================================
  Files          46       46           
  Lines        1594     1594           
=======================================
  Hits          914      914           
  Misses        680      680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit ce03d71 into finos:main Oct 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants