add get project entities by classifier API #476
Conversation
YannanGao-gs
force-pushed
the
classifier
branch
from
010a507
to
e204243
Compare
|
this looks good to me. |
| @ApiParam("Whether to return start of dependency tree") boolean includeOrigin, | ||
| @Context Request request) | ||
| { | ||
| return handle(GET_VERSION_DEPENDENCY_ENTITIES, () -> this.entitiesService.getDependenciesEntitiesByClassifier(groupId, artifactId, versionId, classifier, transitive, includeOrigin), request, () -> EtagBuilder.create().withGAV(groupId, artifactId, versionId).withClassifier(classifier).build()); |
There was a problem hiding this comment.
etag might not completely work , if transitive/origin is true or false we should expect a diff response,
with this it might probably give me the same response irrespective transitive true/false.
There was a problem hiding this comment.
Seems that it should be fine by reading https://stackoverflow.com/questions/78770684/should-etags-be-unique-for-same-url-but-with-different-request-parameters I've tested (only few times), it seems that I can get correct responses.
May I know when/how you got a wrong response?
...main/java/org/finos/legend/depot/server/resources/entities/EntitiesDependenciesResource.java
Outdated
Show resolved
Hide resolved
...main/java/org/finos/legend/depot/server/resources/entities/EntitiesDependenciesResource.java
Show resolved
Hide resolved
...main/java/org/finos/legend/depot/server/resources/entities/EntitiesDependenciesResource.java
Outdated
Show resolved
Hide resolved
YannanGao-gs
force-pushed
the
classifier
branch
from
e204243
to
1298c39
Compare
|
looks good to me |
add get project entities by classifier API