Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized strings ? #110

Closed
LeChatNoir69 opened this issue Aug 9, 2016 · 10 comments
Closed

Localized strings ? #110

LeChatNoir69 opened this issue Aug 9, 2016 · 10 comments

Comments

@LeChatNoir69
Copy link

LeChatNoir69 commented Aug 9, 2016

Hi there,
Objective-C under iOS9, last Firebase SDK, last FirebaseUI version.
I try to add French support.
So I just copy/paste strings from the FirebaseAuthUI.strings in my own .strings files but it doesn't work.

I then try to add FirebaseAuthUI.strings in my project but not better.

I can't get it work.

Any idea ?

Anyway, thxs for the great job :)

@LeChatNoir69
Copy link
Author

Is this a real bug ?

@morganchen12
Copy link
Contributor

This is a bug on the framework's side. Localization is something we'd like to do all at once, rather than one locale at a time.

Unfortunately I'm not sure when we'll get around to doing that.

@LeChatNoir69
Copy link
Author

Ok. I understood that we can override strings file in our app project…
Can I help in something (i’m french so I can at least produce the french file :))

Le 16 août 2016 à 19:12, Morgan Chen notifications@github.com a écrit :

This is a bug on the framework's side. Localization is something we'd like to do all at once, rather than one locale at a time.

Unfortunately I'm not sure when we'll get around to doing that.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #110 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABJZOpXOO4SWHECSNMajkDgH0FkuOS4tks5qge91gaJpZM4JgiRa.

@ch40w31
Copy link
Contributor

ch40w31 commented Aug 16, 2016

I think if you set the custom bundle like this, you should be able to use your own translations.
authUI.customStringsBundle = [NSBundle mainBundle];

@LeChatNoir69
Copy link
Author

You’re right, It works :)
Thxs !

Le 16 août 2016 à 23:02, Chao Wei notifications@github.com a écrit :

I think if you set the custom bundle like this, you should be able to use your own translations.
authUI.customStringsBundle = [NSBundle mainBundle];


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #110 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABJZOiSpI0AYfHjnSgrOnRF5GX4y-z_iks5qgiVqgaJpZM4JgiRa.

@ch40w31
Copy link
Contributor

ch40w31 commented Aug 16, 2016

Great! Thanks for the quick verification.

For anyone running into the same issue, this is documented at https://github.com/firebase/FirebaseUI-iOS/tree/master/FirebaseUI/Auth#custom-strings

@ch40w31 ch40w31 closed this as completed Aug 16, 2016
@jrbecart
Copy link

Hi, like LeChatNoir69 I try to add french to my project.

I'am kind of lost, can I accomplish this using Podfile or should I do a manual install of FirebaseAuthUI in my project?

I already added in my appdelegate this lines:

FUIAuth *authUI = [FUIAuth defaultAuthUI];
authUI.customStringsBundle = [NSBundle mainBundle];

And I also added in my folder String:
->en.lproj->FirebaseAuthUI.strings
->fr.lproj->FirebaseAuthUI.strings

But I can't see any change in the UI.
I'm not sure how to proceed. Any clues?

@LeChatNoir69
Copy link
Author

You just have to define theses strings files in your project :
FirebaseAuthUI.strings
FirebaseFacebookAuthUI.strings
FirebaseGoogleAuthUI.strings

Just look at theses files in the project and you'll find all keys too translate.

@yorgosg
Copy link

yorgosg commented May 25, 2017

@LeChatNoir69 , @jrbecart it is not as easy as it sounds. I have been trying to do this for a while now without any success. Check this question from 4-5 months ago here: #125

If, however, there has been an update on this and now it works, please let me know. Cheers.

@jrbecart
Copy link

jrbecart commented May 25, 2017

@LeChatNoir69 It works!!!

I added this missing files:
FirebaseFacebookAuthUI.strings
FirebaseGoogleAuthUI.strings
and Twitter

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants