chore: Update Typescript to 4.x (#1541)

This is the second PR of a series of changes to update @google-cloud/firestore dependency to 5.x. This is a follow-up to #1540 - Upgraded Typescript from ~3.7.3 to ~4.4.3 - Fixed TS2790: The operand of a 'delete' operator must be optional errors Note: Manually tested for backwards compatibility on TS 3.7.x to 4.5.x. We will add TS compatibility tests to CIs in the future.
firebase · Jan 14, 2022 · d8a3afa · d8a3afa
1 parent db137e9
commit d8a3afa
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -218,7 +218,7 @@
     "sinon": "^9.0.0",
     "sinon-chai": "^3.0.0",
     "ts-node": "^10.2.0",
-    "typescript": "^3.7.3",
+    "typescript": "^4.4.3",
     "yargs": "^17.0.1"
   }
 }
diff --git a/test/integration/auth.spec.ts b/test/integration/auth.spec.ts
@@ -1259,7 +1259,7 @@ describe('admin.auth', () => {
           const actualTenantObj = actualTenant.toJSON();
           if (authEmulatorHost) {
             // Not supported in Auth Emulator
-            delete (actualTenantObj as {testPhoneNumbers: Record<string, string>}).testPhoneNumbers;
+            delete (actualTenantObj as {testPhoneNumbers?: Record<string, string>}).testPhoneNumbers;
             delete expectedCreatedTenant.testPhoneNumbers;
           }
           expect(actualTenantObj).to.deep.equal(expectedCreatedTenant);
@@ -1617,7 +1617,7 @@ describe('admin.auth', () => {
           const actualTenantObj = actualTenant.toJSON();
           if (authEmulatorHost) {
             // Not supported in Auth Emulator
-            delete (actualTenantObj as {testPhoneNumbers: Record<string, string>}).testPhoneNumbers;
+            delete (actualTenantObj as {testPhoneNumbers?: Record<string, string>}).testPhoneNumbers;
             delete expectedCreatedTenant.testPhoneNumbers;
           }
           expect(actualTenantObj).to.deep.equal(expectedCreatedTenant);
@@ -1649,15 +1649,15 @@ describe('admin.auth', () => {
           .then((actualTenant) => {
             const actualTenantObj = actualTenant.toJSON();
             // Not supported in Auth Emulator
-            delete (actualTenantObj as {testPhoneNumbers: Record<string, string>}).testPhoneNumbers;
+            delete (actualTenantObj as {testPhoneNumbers?: Record<string, string>}).testPhoneNumbers;
             delete expectedUpdatedTenant.testPhoneNumbers;
             expect(actualTenantObj).to.deep.equal(expectedUpdatedTenant);
             return getAuth().tenantManager().updateTenant(createdTenantId, updatedOptions2);
           })
           .then((actualTenant) => {
             const actualTenantObj = actualTenant.toJSON();
             // Not supported in Auth Emulator
-            delete (actualTenantObj as {testPhoneNumbers: Record<string, string>}).testPhoneNumbers;
+            delete (actualTenantObj as {testPhoneNumbers?: Record<string, string>}).testPhoneNumbers;
             delete expectedUpdatedTenant2.testPhoneNumbers;
             expect(actualTenantObj).to.deep.equal(expectedUpdatedTenant2);
           });
@@ -2150,8 +2150,8 @@ describe('admin.auth', () => {
           // Not supported in ID token,
           delete decodedIdToken.nonce;
           // exp and iat may vary depending on network connection latency.
-          delete decodedIdToken.exp;
-          delete decodedIdToken.iat;
+          delete (decodedIdToken as any).exp;
+          delete (decodedIdToken as any).iat;
           expect(decodedIdToken).to.deep.equal(payloadClaims);
         });
     });

diff --git a/test/unit/auth/tenant.spec.ts b/test/unit/auth/tenant.spec.ts
@@ -86,15 +86,15 @@ describe('Tenant', () => {
       it('should return the expected server request without multi-factor and phone config', () => {
         const tenantOptionsClientRequest = deepCopy(clientRequestWithoutMfa);
         const tenantOptionsServerRequest = deepCopy(serverRequestWithoutMfa);
-        delete tenantOptionsServerRequest.name;
+        delete (tenantOptionsServerRequest as any).name;
         expect(Tenant.buildServerRequest(tenantOptionsClientRequest, !createRequest))
           .to.deep.equal(tenantOptionsServerRequest);
       });
 
       it('should return the expected server request with multi-factor and phone config', () => {
         const tenantOptionsClientRequest = deepCopy(clientRequest);
         const tenantOptionsServerRequest = deepCopy(serverRequest);
-        delete tenantOptionsServerRequest.name;
+        delete (tenantOptionsServerRequest as any).name;
         expect(Tenant.buildServerRequest(tenantOptionsClientRequest, !createRequest))
           .to.deep.equal(tenantOptionsServerRequest);
       });
@@ -134,7 +134,7 @@ describe('Tenant', () => {
         const tenantOptionsClientRequest = deepCopy(clientRequest);
         const tenantOptionsServerRequest = deepCopy(serverRequest);
         tenantOptionsClientRequest.testPhoneNumbers = null;
-        delete tenantOptionsServerRequest.name;
+        delete (tenantOptionsServerRequest as any).name;
         tenantOptionsServerRequest.testPhoneNumbers = {};
 
         expect(Tenant.buildServerRequest(tenantOptionsClientRequest, !createRequest))
@@ -181,7 +181,7 @@ describe('Tenant', () => {
       it('should return the expected server request without multi-factor and phone config', () => {
         const tenantOptionsClientRequest: CreateTenantRequest = deepCopy(clientRequestWithoutMfa);
         const tenantOptionsServerRequest: TenantServerResponse = deepCopy(serverRequestWithoutMfa);
-        delete tenantOptionsServerRequest.name;
+        delete (tenantOptionsServerRequest as any).name;
 
         expect(Tenant.buildServerRequest(tenantOptionsClientRequest, createRequest))
           .to.deep.equal(tenantOptionsServerRequest);
@@ -190,7 +190,7 @@ describe('Tenant', () => {
       it('should return the expected server request with multi-factor and phone config', () => {
         const tenantOptionsClientRequest: CreateTenantRequest = deepCopy(clientRequest);
         const tenantOptionsServerRequest: TenantServerResponse = deepCopy(serverRequest);
-        delete tenantOptionsServerRequest.name;
+        delete (tenantOptionsServerRequest as any).name;
 
         expect(Tenant.buildServerRequest(tenantOptionsClientRequest, createRequest))
           .to.deep.equal(tenantOptionsServerRequest);
@@ -224,7 +224,7 @@ describe('Tenant', () => {
         const tenantOptionsClientRequest = deepCopy(clientRequest);
         const tenantOptionsServerRequest = deepCopy(serverRequest);
         tenantOptionsClientRequest.testPhoneNumbers = null;
-        delete tenantOptionsServerRequest.name;
+        delete (tenantOptionsServerRequest as any).name;
         tenantOptionsServerRequest.testPhoneNumbers = {};
 
         expect(() => {

diff --git a/test/unit/security-rules/security-rules.spec.ts b/test/unit/security-rules/security-rules.spec.ts
@@ -825,7 +825,7 @@ describe('SecurityRules', () => {
 
     it('should resolve with RulesetMetadataList when the response contains no page token', () => {
       const response = deepCopy(LIST_RULESETS_RESPONSE);
-      delete response.nextPageToken;
+      delete (response as any).nextPageToken;
       const stub = sinon
         .stub(SecurityRulesApiClient.prototype, 'listRulesets')
         .resolves(response);