-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updated package.json file for entry points #1176
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
test/integration/typescript/src/example-modular.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,127 @@ | ||
/*! | ||
* @license | ||
* Copyright 2021 Google Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { expect } from 'chai'; | ||
|
||
import { cert, deleteApp, initializeApp, App } from 'firebase-admin/app'; | ||
import { getAuth, Auth } from 'firebase-admin/auth'; | ||
import { getDatabase, getDatabaseWithUrl, Database, ServerValue } from 'firebase-admin/database'; | ||
import { getFirestore, DocumentReference, Firestore, FieldValue } from 'firebase-admin/firestore'; | ||
import { getInstanceId, InstanceId } from 'firebase-admin/instance-id'; | ||
import { getMachineLearning, MachineLearning } from 'firebase-admin/machine-learning'; | ||
import { getMessaging, Messaging } from 'firebase-admin/messaging'; | ||
import { getProjectManagement, ProjectManagement } from 'firebase-admin/project-management'; | ||
import { getRemoteConfig, RemoteConfig } from 'firebase-admin/remote-config'; | ||
import { getSecurityRules, SecurityRules } from 'firebase-admin/security-rules'; | ||
import { getStorage, Storage } from 'firebase-admin/storage'; | ||
|
||
import { Bucket } from '@google-cloud/storage'; | ||
|
||
|
||
// eslint-disable-next-line @typescript-eslint/no-var-requires | ||
const serviceAccount = require('../mock.key.json'); | ||
|
||
describe('Modular API', () => { | ||
let app: App; | ||
|
||
before(() => { | ||
app = initializeApp({ | ||
credential: cert(serviceAccount), | ||
databaseURL: 'https://mock.firebaseio.com' | ||
}, 'TestApp'); | ||
}); | ||
|
||
after(() => { | ||
return deleteApp(app); | ||
}); | ||
|
||
it('Should return an initialized App', () => { | ||
expect(app.name).to.equal('TestApp'); | ||
}); | ||
|
||
it('Should return an Auth client', () => { | ||
const client = getAuth(app); | ||
expect(client).to.be.instanceOf(Auth); | ||
}); | ||
|
||
it('Should return a Messaging client', () => { | ||
const client = getMessaging(app); | ||
expect(client).to.be.instanceOf(Messaging); | ||
}); | ||
|
||
it('Should return a ProjectManagement client', () => { | ||
const client = getProjectManagement(app); | ||
expect(client).to.be.instanceOf(ProjectManagement); | ||
}); | ||
|
||
it('Should return a SecurityRules client', () => { | ||
const client = getSecurityRules(app); | ||
expect(client).to.be.instanceOf(SecurityRules); | ||
}); | ||
|
||
it('Should return a Database client', () => { | ||
const db: Database = getDatabase(app); | ||
expect(db).to.be.not.undefined; | ||
expect(typeof db.getRules).to.equal('function'); | ||
}); | ||
|
||
it('Should return a Database client for URL', () => { | ||
const db: Database = getDatabaseWithUrl('https://other-mock.firebaseio.com', app); | ||
expect(db).to.be.not.undefined; | ||
expect(typeof db.getRules).to.equal('function'); | ||
}); | ||
|
||
it('Should return a Database ServerValue', () => { | ||
expect(ServerValue.increment(1)).to.be.not.undefined; | ||
}); | ||
|
||
it('Should return a Cloud Storage client', () => { | ||
const storage = getStorage(app); | ||
expect(storage).to.be.instanceOf(Storage) | ||
const bucket: Bucket = storage.bucket('TestBucket'); | ||
expect(bucket.name).to.equal('TestBucket'); | ||
}); | ||
|
||
it('Should return a Firestore client', () => { | ||
const firestore = getFirestore(app); | ||
expect(firestore).to.be.instanceOf(Firestore); | ||
}); | ||
|
||
it('Should return a Firestore FieldValue', () => { | ||
expect(FieldValue.increment(1)).to.be.not.undefined; | ||
}); | ||
|
||
it('Should return a DocumentReference', () => { | ||
const ref = getFirestore(app).collection('test').doc(); | ||
expect(ref).to.be.instanceOf(DocumentReference); | ||
}); | ||
|
||
it('Should return an InstanceId client', () => { | ||
const client = getInstanceId(app); | ||
expect(client).to.be.instanceOf(InstanceId); | ||
}); | ||
|
||
it('Should return a MachineLearning client', () => { | ||
const client = getMachineLearning(app); | ||
expect(client).to.be.instanceOf(MachineLearning); | ||
}); | ||
|
||
it('Should return a RemoteConfig client', () => { | ||
const client = getRemoteConfig(app); | ||
expect(client).to.be.instanceOf(RemoteConfig); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Cloud Function still support Node 10? If so, will this prevents people from using
admin-node
with Node 10 in Cloud Function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Their early reaction was that this change is ok. Functions are already defaulting to Node 12 for all new deployments. We will of course bump our major version to indicate this change when we eventually release this.