-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue 2467: add async to send each loop to prevent local validation #2469
fix: issue 2467: add async to send each loop to prevent local validation #2469
Conversation
…rom throwing in an unknown state
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @DyosTheNerd for the contribution.
no probs :) @jonathanedey as branch is out of date, do you need me to update the branch, or will it automatically be done on merge from your side? |
Yes @DyosTheNerd could you update the branch. Updating on your side makes it easier in case there are any conflicts. Thanks! |
Discussion
adds async to send each loop to prevent local validation from throwing errors which could result in messages being sent and accepted by the api, while the function would still throw an error.
Testing
adds a test with a successful message and one that does not pass local validation. Previously, this would throw an error.