Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DOM from lib #305

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Remove DOM from lib #305

merged 2 commits into from
Jul 16, 2018

Conversation

mmermerkaya
Copy link
Contributor

Added DOM types manually. We should keep these in sync with any spec changes.

Also removed ES5 and ES2015.Promise from lib as they are already included in ES2015.

Based on offline discussion about #286. Notification types are based on NotificationOptions from TypeScript.

Added DOM types manually. We should keep these in sync with any spec changes.

Also removed ES5 and ES2015.Promise from lib as they are already included in ES2015.
@hiranya911 hiranya911 self-assigned this Jul 13, 2018
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM.

Can you also add an entry to the CHANGELOG.md file, so we don't forget to mention this change in our release notes? Feel free to merge once that is done.

@hiranya911 hiranya911 assigned mmermerkaya and unassigned hiranya911 Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants