Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install NDK r21 on GitHub Actions #3961

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Install NDK r21 on GitHub Actions #3961

merged 1 commit into from
Aug 3, 2022

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Aug 2, 2022 •
edited
Loading

NDK r21 is no longer provided by default on GitHub Actions.

actions/runner-images#5930

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022 •
edited
Loading

Unit Test Results

   391 files  +   391     391 suites  +391   16m 36s ⏱️ + 16m 36s
4 697 tests +4 697  4 674 ✔️ +4 674  22 💤 +22  1 ❌ +1 
4 713 runs  +4 713  4 690 ✔️ +4 690  22 💤 +22  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 724021e. ± Comparison against base commit 8cc5d4a.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2022 •
edited
Loading

Coverage Report 1

This report is too large (203,456 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

Notes

  • Commit (4a0b0e6) is created by Prow via merging PR base commit (8cc5d4a) and head commit (724021e).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4hIKs4ZqkM.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (8cc5d4a) and merge commit (4a0b0e6).

Test Logs

Notes

  • Commit (4a0b0e6) is created by Prow via merging PR base commit (8cc5d4a) and head commit (724021e).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iUmt9Oj8xd.html

@yifanyang yifanyang requested a review from vkryachko August 3, 2022 16:26
vkryachko
vkryachko reviewed Aug 3, 2022
View reviewed changes
.github/workflows/ci_tests_experimental.yml
SDKMANAGER=${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager
echo "y" | $SDKMANAGER "ndk;21.4.7075529"
ln -sfn ${ANDROID_SDK_ROOT}/ndk/21.4.7075529 ${ANDROID_NDK_ROOT}
echo "ANDROID_NDK_HOME=${ANDROID_NDK_ROOT}" >> $GITHUB_ENV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is new, why do we need this GITHUB_ENV line?

@yifanyang
Copy link
Contributor Author

/retest

@yifanyang
Copy link
Contributor Author

/test check-changed

1 similar comment
@yifanyang
Copy link
Contributor Author

/test check-changed

@yifanyang yifanyang merged commit 381bf87 into master Aug 3, 2022
@yifanyang yifanyang deleted the yifany/gha-ndk branch August 3, 2022 18:55
@vkryachko vkryachko mentioned this pull request Aug 4, 2022
Merged
lfkellogg pushed a commit that referenced this pull request Aug 5, 2022
@yifanyang @lfkellogg
Install NDK r21 on GitHub Actions (#3961)
e430e86 
NDK r21 is no longer provided by default on GitHub Actions.

actions/runner-images#5930
@firebase firebase locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yifanyang @google-oss-bot @vkryachko