Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README files #4857

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Add README files #4857

merged 4 commits into from
Apr 6, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 5, 2023

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (889d2ac) to 46.70% (adb5f81) by ?.

    12 individual files with coverage change

    FilenameBase (889d2ac)Merge (adb5f81)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?90.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?22.73%?
    SessionInitiator.kt?0.00%?
    SessionsSettings.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GX1UU3bPPM.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

Unit Test Results

14 files  14 suites   21s ⏱️
16 tests 16 ✔️ 0 💤 0 ❌
32 runs  32 ✔️ 0 💤 0 ❌

Results for commit 60a1b29.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 5, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (889d2ac)Merge (adb5f81)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (889d2ac)Merge (adb5f81)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (889d2ac)Merge (adb5f81)Diff
    aar?39.4 kB? (?)
    apk (aggressive)?250 kB? (?)
    apk (release)?1.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dJ2YWbwisn.html

@mrober mrober changed the title Fix test app and add README's Add README files Apr 5, 2023
visumickey
visumickey approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. This is insanely helpful, often overlooked.

firebase-sessions/README.md Show resolved Hide resolved
firebase-sessions/README.md Show resolved Hide resolved
@mrober mrober merged commit 0d7f778 into firebase-sessions Apr 6, 2023
@mrober mrober deleted the sessions-readmes branch April 6, 2023 15:20
@firebase firebase locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees
No one assigned
Labels
api: sessions no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @visumickey @samedson