Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto index Creation Experiment #5064

Closed
wants to merge 41 commits into from

Conversation

cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Jun 7, 2023

This experiment provides the number used in RELATIVE_INDEX_READ_COST_PER_DOCUMENT for #4987 .
It runs query locally on collection contains 10 ~ 100 documents, compares the time spent between full collection scan and index look up. And the result relative number is used in Android SDK to decide whether index will help improve local query performance.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@cherylEnkidu cherylEnkidu changed the base branch from master to cheryllin/autoindexing June 7, 2023 17:24
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.PersistentCacheSettings.autoClientIndexingEnabled() [AddedMethod]
error: Added method com.google.firebase.firestore.PersistentCacheSettings.Builder.enableAutoClientIndexing(boolean) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 7, 2023

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.63% (6349a09) to 44.64% (153d70a) by +0.01%.

    FilenameBase (6349a09)Merge (153d70a)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    QueryEngine.java99.00%98.13%-0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ipGev46pYj.html

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Unit Test Results

   166 files  +2     166 suites  +2   3m 4s ⏱️ +46s
1 206 tests +1  1 190 ✔️ +1  16 💤 ±0  0 ±0 
2 412 runs  +2  2 380 ✔️ +2  32 💤 ±0  0 ±0 

Results for commit 42e41ac. ± Comparison against base commit 6349a09.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 7, 2023

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (6349a09)Merge (153d70a)Diff
    aar1.36 MB1.36 MB+194 B (+0.0%)
    apk (release)3.95 MB3.95 MB+368 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NWW0L7rNoy.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 7, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (80ce37a) and the base commit (dff55b6) are not available.

No macrobenchmark data found for the base commit (dff55b6). Analysis for the CI merge commit (80ce37a) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nfg8Dp5KH0/index.html

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexExperiment branch from dd34db3 to d542173 Compare June 15, 2023 13:31
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoindexing branch 3 times, most recently from 1022b65 to 206606d Compare June 27, 2023 04:01
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexExperiment branch from 5e5808d to 69eac52 Compare June 27, 2023 16:03
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexExperiment branch from 69eac52 to 2d2a433 Compare June 27, 2023 16:03
@firebase firebase deleted a comment from google-oss-bot Jun 27, 2023
@firebase firebase deleted a comment from google-oss-bot Jun 27, 2023
@firebase firebase deleted a comment from google-oss-bot Jun 27, 2023
@firebase firebase deleted a comment from google-oss-bot Jun 27, 2023
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexExperiment branch from d4b04fc to 2d2a433 Compare June 28, 2023 20:59
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexExperiment branch from 71b12be to f4c0574 Compare July 25, 2023 16:46
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/autoIndexExperiment branch from 311c002 to 2f7a254 Compare July 26, 2023 17:28
Base automatically changed from cheryllin/autoindexing to master July 26, 2023 22:12
@firebase firebase locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants