Make default sampling rates for when RC fetch failed 1/1000 typical #5071

mrober · 2023-06-08T21:15:30Z

Make default sampling rates for when RC fetch failed 1/1000 typical default.

…efault

github-actions · 2023-06-08T21:15:44Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

google-oss-bot · 2023-06-08T21:24:28Z

Coverage Report ¹

Affected Products

No changes between base commit (ad22aeb) and merge commit (4e8f534).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/CvUqlNi82h.html

github-actions · 2023-06-08T21:27:06Z

Unit Test Results

  102 files +    68   102 suites +68 2m 53s ⏱️ + 1m 51s
  981 tests +  923   981 ✔️ +  923 0 💤 ±0 0 ❌ ±0
1 962 runs +1 846 1 962 ✔️ +1 846 0 💤 ±0 0 ❌ ±0

Results for commit 4ec336a. ± Comparison against base commit ad22aeb.

This pull request removes 58 and adds 981 tests. Note that renamed tests count towards both.

com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
…

com.google.firebase.perf.FirebasePerfRegistrarTest ‑ testGetComponents
com.google.firebase.perf.FirebasePerformanceTest ‑ firebasePerformanceInitialization_providesRcProvider_remoteConfigManagerIsSet
com.google.firebase.perf.FirebasePerformanceTest ‑ initFirebasePerformance_injectsMetadataIntoConfigResolver
com.google.firebase.perf.FirebasePerformanceTest ‑ initializeFirebasePerformance_emptyMetadataAndCache_metadataAndContextInjected
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsManifestTrue
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsManifestFalse
com.google.firebase.perf.FirebasePerformanceTest ‑ testAddingMoreThanMaxLocalAttributes
com.google.firebase.perf.FirebasePerformanceTest ‑ testBothManifestsAgree
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-06-08T21:38:31Z

Size Report ¹

Affected Products

firebase-perf
Type Base (ad22aeb) Merge (4e8f534) Diff
aar 316 kB 316 kB +90 B (+0.0%)
apk (aggressive) 1.06 MB 1.06 MB +72 B (+0.0%)
apk (release) 3.06 MB 3.06 MB +144 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/lXQHmMCHxF.html

google-oss-bot · 2023-06-08T22:10:03Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (ad22aeb) and the CI merge commit (4e8f534)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- ad22aeb: https://storage.googleapis.com/firebase-sdk-metric-reports/ejs7tDpSod/index.html
- 4e8f534: https://storage.googleapis.com/firebase-sdk-metric-reports/fnURTxlHsE/index.html

Startup Times

`fire-perf`

Device Statistics Distributions

oriole-32

Percentile	`ad22aeb`	`4e8f534`	Diff	Significant (?)
p10	254 ±16 μs	253 ±23 μs	-712 ns (-0.3%)	NO
p25	268 ±15 μs	265 ±22 μs	-3.49 μs (-1.3%)	NO
p50	290 ±20 μs	286 ±22 μs	-4.07 μs (-1.4%)	NO
p75	331 ±26 μs	325 ±24 μs	-5.99 μs (-1.8%)	NO
p90	388 ±27 μs	376 ±29 μs	-12.0 μs (-3.1%)	NO

20 test runs in comparison

Commit	Test Runs
`ad22aeb`	2023-06-07_21:25:52.471867_krzZ 2023-06-07_21:25:52.475037_orbW 2023-06-07_21:25:52.475057_AkNj 2023-06-07_21:25:52.475065_gejR 2023-06-07_21:25:52.475071_jSsV 2023-06-07_21:25:52.475078_AujW 2023-06-07_21:25:52.475084_Labj 2023-06-07_21:25:52.475091_rpXi 2023-06-07_21:25:52.475097_WhrU 2023-06-07_21:25:52.475103_dXnT
`4e8f534`	2023-06-08_21:55:47.649325_EbMo 2023-06-08_21:55:47.653028_tfFm 2023-06-08_21:55:47.653042_cmmF 2023-06-08_21:55:47.653047_WOAn 2023-06-08_21:55:47.653054_zvYr 2023-06-08_21:55:47.653060_CSIU 2023-06-08_21:55:47.653066_KaYu 2023-06-08_21:55:47.653072_lgdZ 2023-06-08_21:55:47.653080_XHZk 2023-06-08_21:55:47.653085_ndAF

redfin-30

Percentile	`ad22aeb`	`4e8f534`	Diff	Significant (?)
p10	782 ±87 μs	789 ±86 μs	+6.32 μs (+0.8%)	NO
p25	816 ±76 μs	826 ±92 μs	+9.87 μs (+1.2%)	NO
p50	865 ±79 μs	886 ±103 μs	+21.1 μs (+2.4%)	NO
p75	944 ±106 μs	980 ±126 μs	+35.7 μs (+3.8%)	NO
p90	1.09 ±0.2 ms	1.14 ±0.2 ms	+48.2 μs (+4.4%)	NO

20 test runs in comparison

Commit	Test Runs
`ad22aeb`	2023-06-07_21:25:52.471867_krzZ 2023-06-07_21:25:52.475037_orbW 2023-06-07_21:25:52.475057_AkNj 2023-06-07_21:25:52.475065_gejR 2023-06-07_21:25:52.475071_jSsV 2023-06-07_21:25:52.475078_AujW 2023-06-07_21:25:52.475084_Labj 2023-06-07_21:25:52.475091_rpXi 2023-06-07_21:25:52.475097_WhrU 2023-06-07_21:25:52.475103_dXnT
`4e8f534`	2023-06-08_21:55:47.649325_EbMo 2023-06-08_21:55:47.653028_tfFm 2023-06-08_21:55:47.653042_cmmF 2023-06-08_21:55:47.653047_WOAn 2023-06-08_21:55:47.653054_zvYr 2023-06-08_21:55:47.653060_CSIU 2023-06-08_21:55:47.653066_KaYu 2023-06-08_21:55:47.653072_lgdZ 2023-06-08_21:55:47.653080_XHZk 2023-06-08_21:55:47.653085_ndAF

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`ad22aeb`	`4e8f534`	Diff	Significant (?)
p10	194 ±3 ms	197 ±6 ms	+3.39 ms (+1.7%)	NO
p25	200 ±3 ms	203 ±6 ms	+2.82 ms (+1.4%)	NO
p50	207 ±3 ms	211 ±6 ms	+3.93 ms (+1.9%)	NO
p75	215 ±4 ms	221 ±7 ms	+5.60 ms (+2.6%)	NO
p90	224 ±5 ms	233 ±13 ms	+8.98 ms (+4.0%)	NO

20 test runs in comparison

Commit	Test Runs
`ad22aeb`	2023-06-07_21:25:52.471867_krzZ 2023-06-07_21:25:52.475037_orbW 2023-06-07_21:25:52.475057_AkNj 2023-06-07_21:25:52.475065_gejR 2023-06-07_21:25:52.475071_jSsV 2023-06-07_21:25:52.475078_AujW 2023-06-07_21:25:52.475084_Labj 2023-06-07_21:25:52.475091_rpXi 2023-06-07_21:25:52.475097_WhrU 2023-06-07_21:25:52.475103_dXnT
`4e8f534`	2023-06-08_21:55:47.649325_EbMo 2023-06-08_21:55:47.653028_tfFm 2023-06-08_21:55:47.653042_cmmF 2023-06-08_21:55:47.653047_WOAn 2023-06-08_21:55:47.653054_zvYr 2023-06-08_21:55:47.653060_CSIU 2023-06-08_21:55:47.653066_KaYu 2023-06-08_21:55:47.653072_lgdZ 2023-06-08_21:55:47.653080_XHZk 2023-06-08_21:55:47.653085_ndAF

redfin-30

Percentile	`ad22aeb`	`4e8f534`	Diff	Significant (?)
p10	231 ±4 ms	255 ±4 ms	+23.1 ms (+10.0%)	YES
p25	238 ±5 ms	260 ±4 ms	+22.2 ms (+9.3%)	MAYBE
p50	245 ±5 ms	268 ±3 ms	+23.2 ms (+9.5%)	MAYBE
p75	254 ±7 ms	276 ±4 ms	+22.9 ms (+9.0%)	MAYBE
p90	263 ±9 ms	290 ±6 ms	+26.9 ms (+10.2%)	NO

20 test runs in comparison

Commit	Test Runs
`ad22aeb`	2023-06-07_21:25:52.471867_krzZ 2023-06-07_21:25:52.475037_orbW 2023-06-07_21:25:52.475057_AkNj 2023-06-07_21:25:52.475065_gejR 2023-06-07_21:25:52.475071_jSsV 2023-06-07_21:25:52.475078_AujW 2023-06-07_21:25:52.475084_Labj 2023-06-07_21:25:52.475091_rpXi 2023-06-07_21:25:52.475097_WhrU 2023-06-07_21:25:52.475103_dXnT
`4e8f534`	2023-06-08_21:55:47.649325_EbMo 2023-06-08_21:55:47.653028_tfFm 2023-06-08_21:55:47.653042_cmmF 2023-06-08_21:55:47.653047_WOAn 2023-06-08_21:55:47.653054_zvYr 2023-06-08_21:55:47.653060_CSIU 2023-06-08_21:55:47.653066_KaYu 2023-06-08_21:55:47.653072_lgdZ 2023-06-08_21:55:47.653080_XHZk 2023-06-08_21:55:47.653085_ndAF

https://storage.googleapis.com/firebase-sdk-metric-reports/Wy6Dqaektt/index.html

…5071) * Make default sampling rates for when RC fetch failed 1/1000 typical default * Fix tests * Change log message to warn and link to support

Make default sampling rates for when RC fetch failed 1/1000 typical d…

06307db

…efault

mrober added the no-changelog label Jun 8, 2023

mrober requested a review from visumickey June 8, 2023 21:15

Fix tests

3778284

Change log message to warn and link to support

4ec336a

visumickey approved these changes Jun 8, 2023

View reviewed changes

mrober enabled auto-merge (squash) June 8, 2023 21:45

mrober merged commit c1be5f9 into master Jun 8, 2023

mrober deleted the fireperf-defaults-3 branch June 8, 2023 21:47

firebase locked and limited conversation to collaborators Jul 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make default sampling rates for when RC fetch failed 1/1000 typical #5071

Make default sampling rates for when RC fetch failed 1/1000 typical #5071

mrober commented Jun 8, 2023

github-actions bot commented Jun 8, 2023 •

edited

Loading

google-oss-bot commented Jun 8, 2023 •

edited

Loading

github-actions bot commented Jun 8, 2023 •

edited

Loading

google-oss-bot commented Jun 8, 2023 •

edited

Loading

`firebase-perf`

google-oss-bot commented Jun 8, 2023

`fire-perf`

`timeToInitialDisplay`

Make default sampling rates for when RC fetch failed 1/1000 typical #5071

Make default sampling rates for when RC fetch failed 1/1000 typical #5071

Conversation

mrober commented Jun 8, 2023

github-actions bot commented Jun 8, 2023 • edited Loading

Release note changes

google-oss-bot commented Jun 8, 2023 • edited Loading

Coverage Report 1

Affected Products

Test Logs

github-actions bot commented Jun 8, 2023 • edited Loading

Unit Test Results

google-oss-bot commented Jun 8, 2023 • edited Loading

Size Report 1

Affected Products

firebase-perf

Test Logs

google-oss-bot commented Jun 8, 2023

Startup Time Report 1

Notes

Startup Times

fire-perf

timeToInitialDisplay

github-actions bot commented Jun 8, 2023 •

edited

Loading

google-oss-bot commented Jun 8, 2023 •

edited

Loading

Coverage Report ¹

github-actions bot commented Jun 8, 2023 •

edited

Loading

google-oss-bot commented Jun 8, 2023 •

edited

Loading

Size Report ¹

`firebase-perf`

Startup Time Report ¹

`fire-perf`

`timeToInitialDisplay`