Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out failing messaging tests #5074

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Comment out failing messaging tests #5074

merged 1 commit into from
Jun 9, 2023

Conversation

emilypgoogle
Copy link
Collaborator

No description provided.

@emilypgoogle emilypgoogle requested a review from rlazo June 9, 2023 16:36
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@emilypgoogle emilypgoogle enabled auto-merge (squash) June 9, 2023 16:42
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from ? (e9d0de9) to 84.18% (7848ec0) by ?.

    41 individual files with coverage change

    FilenameBase (e9d0de9)Merge (7848ec0)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?73.57%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.78%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?41.27%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?80.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?73.33%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?88.60%?
    TopicsSyncTask.java?49.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NiaOb4TRVo.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (e9d0de9) and merge commit (7848ec0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Cz7PwHBocu.html

@emilypgoogle emilypgoogle merged commit f76f697 into master Jun 9, 2023
@emilypgoogle emilypgoogle deleted the ep/messaging-bug branch June 9, 2023 16:48
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fcm

    DeviceStatisticsDistributions
    oriole-32
    Percentilee9d0de97848ec0DiffSignificant (?)
    p101.11 ±2 ms1.36 ±2 ms+254 μs (+23.0%)NO
    p251.16 ±2 ms1.44 ±2 ms+281 μs (+24.3%)NO
    p501.27 ±2 ms1.59 ±2 ms+327 μs (+25.8%)NO
    p751.49 ±2 ms1.86 ±2 ms+366 μs (+24.5%)NO
    p901.75 ±2 ms2.18 ±2 ms+427 μs (+24.4%)NO

    20 test runs in comparison
    CommitTest Runs
    e9d0de9
    • 2023-06-09_16:11:29.591192_hjcR
    • 2023-06-09_16:11:29.593779_LvIA
    • 2023-06-09_16:11:29.593794_BdQG
    • 2023-06-09_16:11:29.593802_cSlJ
    • 2023-06-09_16:11:29.593809_iRyS
    • 2023-06-09_16:11:29.593815_saCA
    • 2023-06-09_16:11:29.593822_hTjO
    • 2023-06-09_16:11:29.593828_VksT
    • 2023-06-09_16:11:29.593838_KQQI
    • 2023-06-09_16:11:29.593845_tInu
    7848ec0
    • 2023-06-09_16:56:04.153784_QmYh
    • 2023-06-09_16:56:04.156579_HWXf
    • 2023-06-09_16:56:04.156600_VxyO
    • 2023-06-09_16:56:04.156608_WKTK
    • 2023-06-09_16:56:04.156616_agjE
    • 2023-06-09_16:56:04.156622_YhDl
    • 2023-06-09_16:56:04.156629_vuhU
    • 2023-06-09_16:56:04.156636_ycgU
    • 2023-06-09_16:56:04.156647_zzPa
    • 2023-06-09_16:56:04.156654_kILp
    redfin-30
    Percentilee9d0de97848ec0DiffSignificant (?)
    p102.57 ±3 ms2.75 ±4 ms+187 μs (+7.3%)NO
    p252.86 ±4 ms3.08 ±4 ms+217 μs (+7.6%)NO
    p503.33 ±4 ms3.60 ±4 ms+270 μs (+8.1%)NO
    p754.09 ±5 ms4.49 ±5 ms+408 μs (+10.0%)NO
    p905.15 ±6 ms5.90 ±6 ms+746 μs (+14.5%)NO

    20 test runs in comparison
    CommitTest Runs
    e9d0de9
    • 2023-06-09_16:11:29.591192_hjcR
    • 2023-06-09_16:11:29.593779_LvIA
    • 2023-06-09_16:11:29.593794_BdQG
    • 2023-06-09_16:11:29.593802_cSlJ
    • 2023-06-09_16:11:29.593809_iRyS
    • 2023-06-09_16:11:29.593815_saCA
    • 2023-06-09_16:11:29.593822_hTjO
    • 2023-06-09_16:11:29.593828_VksT
    • 2023-06-09_16:11:29.593838_KQQI
    • 2023-06-09_16:11:29.593845_tInu
    7848ec0
    • 2023-06-09_16:56:04.153784_QmYh
    • 2023-06-09_16:56:04.156579_HWXf
    • 2023-06-09_16:56:04.156600_VxyO
    • 2023-06-09_16:56:04.156608_WKTK
    • 2023-06-09_16:56:04.156616_agjE
    • 2023-06-09_16:56:04.156622_YhDl
    • 2023-06-09_16:56:04.156629_vuhU
    • 2023-06-09_16:56:04.156636_ycgU
    • 2023-06-09_16:56:04.156647_zzPa
    • 2023-06-09_16:56:04.156654_kILp

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilee9d0de97848ec0DiffSignificant (?)
    p10192 ±3 ms194 ±2 ms+2.75 ms (+1.4%)NO
    p25198 ±4 ms201 ±2 ms+3.61 ms (+1.8%)NO
    p50205 ±4 ms209 ±2 ms+3.89 ms (+1.9%)NO
    p75214 ±4 ms218 ±4 ms+4.60 ms (+2.2%)NO
    p90222 ±4 ms233 ±9 ms+10.6 ms (+4.8%)NO

    20 test runs in comparison
    CommitTest Runs
    e9d0de9
    • 2023-06-09_16:11:29.591192_hjcR
    • 2023-06-09_16:11:29.593779_LvIA
    • 2023-06-09_16:11:29.593794_BdQG
    • 2023-06-09_16:11:29.593802_cSlJ
    • 2023-06-09_16:11:29.593809_iRyS
    • 2023-06-09_16:11:29.593815_saCA
    • 2023-06-09_16:11:29.593822_hTjO
    • 2023-06-09_16:11:29.593828_VksT
    • 2023-06-09_16:11:29.593838_KQQI
    • 2023-06-09_16:11:29.593845_tInu
    7848ec0
    • 2023-06-09_16:56:04.153784_QmYh
    • 2023-06-09_16:56:04.156579_HWXf
    • 2023-06-09_16:56:04.156600_VxyO
    • 2023-06-09_16:56:04.156608_WKTK
    • 2023-06-09_16:56:04.156616_agjE
    • 2023-06-09_16:56:04.156622_YhDl
    • 2023-06-09_16:56:04.156629_vuhU
    • 2023-06-09_16:56:04.156636_ycgU
    • 2023-06-09_16:56:04.156647_zzPa
    • 2023-06-09_16:56:04.156654_kILp
    redfin-30
    Percentilee9d0de97848ec0DiffSignificant (?)
    p10233 ±3 ms255 ±4 ms+22.3 ms (+9.6%)YES
    p25239 ±3 ms262 ±4 ms+22.7 ms (+9.5%)YES
    p50247 ±4 ms269 ±4 ms+21.8 ms (+8.8%)YES
    p75254 ±4 ms278 ±5 ms+23.6 ms (+9.3%)YES
    p90264 ±5 ms291 ±7 ms+26.9 ms (+10.2%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    e9d0de9
    • 2023-06-09_16:11:29.591192_hjcR
    • 2023-06-09_16:11:29.593779_LvIA
    • 2023-06-09_16:11:29.593794_BdQG
    • 2023-06-09_16:11:29.593802_cSlJ
    • 2023-06-09_16:11:29.593809_iRyS
    • 2023-06-09_16:11:29.593815_saCA
    • 2023-06-09_16:11:29.593822_hTjO
    • 2023-06-09_16:11:29.593828_VksT
    • 2023-06-09_16:11:29.593838_KQQI
    • 2023-06-09_16:11:29.593845_tInu
    7848ec0
    • 2023-06-09_16:56:04.153784_QmYh
    • 2023-06-09_16:56:04.156579_HWXf
    • 2023-06-09_16:56:04.156600_VxyO
    • 2023-06-09_16:56:04.156608_WKTK
    • 2023-06-09_16:56:04.156616_agjE
    • 2023-06-09_16:56:04.156622_YhDl
    • 2023-06-09_16:56:04.156629_vuhU
    • 2023-06-09_16:56:04.156636_ycgU
    • 2023-06-09_16:56:04.156647_zzPa
    • 2023-06-09_16:56:04.156654_kILp

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dmxRCBR2RG/index.html

davidmotson pushed a commit that referenced this pull request Jun 20, 2023
@emilypgoogle
Comment out failing messaging tests (#5074)
54c1cac
@firebase firebase locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilypgoogle @google-oss-bot @rlazo