Finish background FCM broadcasts after handling the message. #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed to finish a background broadcast after the message has been handled, subject to a timeout. This keeps the `FirebaseMessagingService`'s process in an active state while it is handling an FCM message, up to the 20 seconds allowed. * Removed acquiring a WakeLock for background broadcasts as one is held for the app until the broadcast is finished.
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-messaging### {{messaging_longer}} version 23.1.3 {: #messaging_v23-1-3}
* {{deprecated}} Deprecated FCM upstream messaging. See the
[FAQ](https://firebase.google.com/support/faq#fcm-23-deprecation) for more
details.
* {{changed}} Changed to finish a background broadcast after the message has been
handled, subject to a timeout. This keeps the `FirebaseMessagingService`'s
process in an active state while it is handling an FCM message, up to the
20 seconds allowed.
#### {{messaging_longer}} Kotlin extensions version 23.1.3 {: #messaging-ktx_v23-1-3}
The Kotlin extensions library transitively includes the updated
`firebase-messaging` library. The Kotlin extensions library has no additional
updates. |
Coverage Report 1Affected Products
Test Logs |
Unit Test Results 54 files ±0 54 suites ±0 6m 58s ⏱️ +6s Results for commit 00bc602. ± Comparison against base commit bf8cb54. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. |
Size Report 1Affected Products
Test Logs |
gsakakihara
requested review from
James201311,
xiaohegong,
welishr and
willxu-google
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
xiaohegong
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FirebaseMessagingService's process in an active state while it is handling an FCM message, up to the 20 seconds allowed.