Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RC to firebase-config. #555

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Move RC to firebase-config. #555

merged 1 commit into from
Jun 21, 2019

Conversation

allisonbm92
Copy link
Contributor

This commit renames the directory to match the artifact id (as with the
other projects), enabling our test and release infrastructure to work as
expected.

@googlebot googlebot added the cla: yes Override cla label Jun 21, 2019
This commit renames the directory to match the artifact id (as with the
other projects), enabling our test and release infrastructure to work as
expected.
Copy link
Contributor

@miraziz miraziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@allisonbm92
Copy link
Contributor Author

/test check-changed
/test device-check-changed

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 21, 2019

@allisonbm92: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 0dc987e link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@allisonbm92 allisonbm92 merged commit 5301121 into master Jun 21, 2019
@allisonbm92 allisonbm92 deleted the allison-rc-rename branch June 21, 2019 20:20
schmidt-sebastian pushed a commit that referenced this pull request Jun 25, 2019
This commit renames the directory to match the artifact id (as with the
other projects), enabling our test and release infrastructure to work as
expected.
schmidt-sebastian pushed a commit that referenced this pull request Jun 27, 2019
This commit renames the directory to match the artifact id (as with the
other projects), enabling our test and release infrastructure to work as
expected.
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants