Pin appcheck-interop dependency to latest released version #6242

rlazo · 2024-09-10T01:47:52Z

There's no need for functions to depend at a project level on the appcheck interop library.

github-actions · 2024-09-10T01:48:07Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2024-09-10T01:48:32Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2024-09-10T01:53:42Z

Coverage Report ¹

Affected Products

No changes between base commit (2eb7cd7) and merge commit (6d64f65).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/g6TAZat5G6.html

github-actions · 2024-09-10T01:57:49Z

Unit Test Results

20 files -   14 20 suites - 14 37s ⏱️ -21s
23 tests - 165 23 ✔️ - 165 0 💤 ±0 0 ❌ ±0
68 runs - 308 68 ✔️ - 308 0 💤 ±0 0 ❌ ±0

Results for commit 2e5109d. ± Comparison against base commit 2eb7cd7.

This pull request removes 188 and adds 23 tests. Note that renamed tests count towards both.

com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_emptyLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_isNotRedirectResponse_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_missingLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_onAppResume_setsUpdateCancelled
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenAabReleaseAvailable_redirectsToPlay
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenOpenConnectionFails_setsNetworkFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateApp_whenCalledMultipleTimesWithAAB_onlyMakesOneRequest
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installActivityDestroyed_setsInstallError
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installApk_currentActivityNotNull_InstallIntentOnCurrentActivity
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ whenCalledMultipleTimes_onlyEmitsOneIntent
…

com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…

google-oss-bot · 2024-09-10T02:00:13Z

Size Report ¹

Affected Products

No changes between base commit (2eb7cd7) and merge commit (6d64f65).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/IBoM7RrdqD.html

google-oss-bot · 2024-09-10T02:18:39Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (2eb7cd7) and the CI merge commit (6d64f65)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 2eb7cd7: https://storage.googleapis.com/firebase-sdk-metric-reports/LCsYH3Bm26/index.html
- 6d64f65: https://storage.googleapis.com/firebase-sdk-metric-reports/iLGdIdItb0/index.html

Startup Times

`fire-fn`

Device Statistics Distributions

oriole-32

Percentile	`2eb7cd7`	`6d64f65`	Diff	Significant (?)
p10	100 ±18 μs	94.6 ±8 μs	-5.46 μs (-5.5%)	NO
p25	109 ±26 μs	99.8 ±9.5 μs	-9.62 μs (-8.8%)	NO
p50	123 ±36 μs	109 ±15 μs	-14.3 μs (-11.6%)	NO
p75	144 ±57 μs	122 ±29 μs	-21.6 μs (-15.0%)	NO
p90	193 ±109 μs	150 ±61 μs	-43.3 μs (-22.4%)	NO

20 test runs in comparison

Commit	Test Runs
`2eb7cd7`	2024-09-05_14:43:18.113963_ZYPh 2024-09-05_14:43:18.114016_bvUl 2024-09-05_14:43:18.114028_gZli 2024-09-05_14:43:18.114037_jaqw 2024-09-05_14:43:18.114045_JJgj 2024-09-05_14:43:18.114053_GhUl 2024-09-05_14:43:18.114061_jxsd 2024-09-05_14:43:18.114073_HJeq 2024-09-05_14:43:18.114084_FpAF 2024-09-05_14:43:18.114092_xCVW
`6d64f65`	2024-09-10_02:04:32.449295_otbP 2024-09-10_02:04:32.449339_LOpM 2024-09-10_02:04:32.449351_kkuA 2024-09-10_02:04:32.449359_euXU 2024-09-10_02:04:32.449367_rhJL 2024-09-10_02:04:32.449374_cNwV 2024-09-10_02:04:32.449382_NgEL 2024-09-10_02:04:32.449388_LhkS 2024-09-10_02:04:32.449395_Lqqs 2024-09-10_02:04:32.449402_EbCY

redfin-30

Percentile	`2eb7cd7`	`6d64f65`	Diff	Significant (?)
p10	174 ±20 μs	178 ±20 μs	+3.69 μs (+2.1%)	NO
p25	180 ±21 μs	187 ±22 μs	+7.92 μs (+4.4%)	NO
p50	187 ±23 μs	200 ±25 μs	+12.5 μs (+6.6%)	NO
p75	199 ±30 μs	220 ±30 μs	+20.5 μs (+10.3%)	NO
p90	215 ±33 μs	255 ±51 μs	+39.7 μs (+18.5%)	NO

20 test runs in comparison

Commit	Test Runs
`2eb7cd7`	2024-09-05_14:43:18.113963_ZYPh 2024-09-05_14:43:18.114016_bvUl 2024-09-05_14:43:18.114028_gZli 2024-09-05_14:43:18.114037_jaqw 2024-09-05_14:43:18.114045_JJgj 2024-09-05_14:43:18.114053_GhUl 2024-09-05_14:43:18.114061_jxsd 2024-09-05_14:43:18.114073_HJeq 2024-09-05_14:43:18.114084_FpAF 2024-09-05_14:43:18.114092_xCVW
`6d64f65`	2024-09-10_02:04:32.449295_otbP 2024-09-10_02:04:32.449339_LOpM 2024-09-10_02:04:32.449351_kkuA 2024-09-10_02:04:32.449359_euXU 2024-09-10_02:04:32.449367_rhJL 2024-09-10_02:04:32.449374_cNwV 2024-09-10_02:04:32.449382_NgEL 2024-09-10_02:04:32.449388_LhkS 2024-09-10_02:04:32.449395_Lqqs 2024-09-10_02:04:32.449402_EbCY

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`2eb7cd7`	`6d64f65`	Diff	Significant (?)
p10	202 ±9 ms	204 ±4 ms	+2.16 ms (+1.1%)	NO
p25	210 ±11 ms	210 ±4 ms	+565 μs (+0.3%)	NO
p50	220 ±20 ms	218 ±4 ms	-2.56 ms (-1.2%)	NO
p75	229 ±25 ms	228 ±4 ms	-1.61 ms (-0.7%)	NO
p90	240 ±31 ms	240 ±9.9 ms	-397 μs (-0.2%)	NO

20 test runs in comparison

Commit	Test Runs
`2eb7cd7`	2024-09-05_14:43:18.113963_ZYPh 2024-09-05_14:43:18.114016_bvUl 2024-09-05_14:43:18.114028_gZli 2024-09-05_14:43:18.114037_jaqw 2024-09-05_14:43:18.114045_JJgj 2024-09-05_14:43:18.114053_GhUl 2024-09-05_14:43:18.114061_jxsd 2024-09-05_14:43:18.114073_HJeq 2024-09-05_14:43:18.114084_FpAF 2024-09-05_14:43:18.114092_xCVW
`6d64f65`	2024-09-10_02:04:32.449295_otbP 2024-09-10_02:04:32.449339_LOpM 2024-09-10_02:04:32.449351_kkuA 2024-09-10_02:04:32.449359_euXU 2024-09-10_02:04:32.449367_rhJL 2024-09-10_02:04:32.449374_cNwV 2024-09-10_02:04:32.449382_NgEL 2024-09-10_02:04:32.449388_LhkS 2024-09-10_02:04:32.449395_Lqqs 2024-09-10_02:04:32.449402_EbCY

redfin-30

Percentile	`2eb7cd7`	`6d64f65`	Diff	Significant (?)
p10	251 ±14 ms	265 ±4 ms	+14.8 ms (+5.9%)	NO
p25	256 ±15 ms	272 ±5 ms	+15.4 ms (+6.0%)	NO
p50	263 ±16 ms	280 ±5 ms	+16.4 ms (+6.2%)	NO
p75	278 ±33 ms	289 ±5 ms	+10.9 ms (+3.9%)	NO
p90	292 ±37 ms	303 ±7 ms	+11.3 ms (+3.9%)	NO

20 test runs in comparison

Commit	Test Runs
`2eb7cd7`	2024-09-05_14:43:18.113963_ZYPh 2024-09-05_14:43:18.114016_bvUl 2024-09-05_14:43:18.114028_gZli 2024-09-05_14:43:18.114037_jaqw 2024-09-05_14:43:18.114045_JJgj 2024-09-05_14:43:18.114053_GhUl 2024-09-05_14:43:18.114061_jxsd 2024-09-05_14:43:18.114073_HJeq 2024-09-05_14:43:18.114084_FpAF 2024-09-05_14:43:18.114092_xCVW
`6d64f65`	2024-09-10_02:04:32.449295_otbP 2024-09-10_02:04:32.449339_LOpM 2024-09-10_02:04:32.449351_kkuA 2024-09-10_02:04:32.449359_euXU 2024-09-10_02:04:32.449367_rhJL 2024-09-10_02:04:32.449374_cNwV 2024-09-10_02:04:32.449382_NgEL 2024-09-10_02:04:32.449388_LhkS 2024-09-10_02:04:32.449395_Lqqs 2024-09-10_02:04:32.449402_EbCY

https://storage.googleapis.com/firebase-sdk-metric-reports/o6Rw2eW2rt/index.html

Pin appcheck-interop dependency to latest released version

2e5109d

There's no need for functions to depend at a project level on the appcheck interop library.

rlazo requested review from VinayGuthal and emilypgoogle September 10, 2024 01:47

google-oss-bot added the size/XS label Sep 10, 2024

VinayGuthal approved these changes Sep 10, 2024

View reviewed changes

rlazo merged commit 1e0e499 into main Sep 10, 2024
35 checks passed

rlazo deleted the rl.functions.appcheck.pin branch September 10, 2024 13:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin appcheck-interop dependency to latest released version #6242

Pin appcheck-interop dependency to latest released version #6242

rlazo commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 •

edited

Loading

google-oss-bot commented Sep 10, 2024

google-oss-bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

google-oss-bot commented Sep 10, 2024

google-oss-bot commented Sep 10, 2024

`fire-fn`

`timeToInitialDisplay`

Pin appcheck-interop dependency to latest released version #6242

Pin appcheck-interop dependency to latest released version #6242

Conversation

rlazo commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 • edited Loading

📝 PRs merging into main branch

google-oss-bot commented Sep 10, 2024

google-oss-bot commented Sep 10, 2024

Coverage Report 1

Affected Products

Test Logs

github-actions bot commented Sep 10, 2024

Unit Test Results

google-oss-bot commented Sep 10, 2024

Size Report 1

Affected Products

Test Logs

google-oss-bot commented Sep 10, 2024

Startup Time Report 1

Notes

Startup Times

fire-fn

timeToInitialDisplay

github-actions bot commented Sep 10, 2024 •

edited

Loading

Coverage Report ¹

Size Report ¹

Startup Time Report ¹

`fire-fn`

`timeToInitialDisplay`