Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnyValue and AnyValueSerializer added #6285

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 20, 2024

Add support the custom Any GraphQL scalar type.

Code generation support for Any scalars in Android was added in the Data Connect Toolkit v1.3.8 (released Sept 20, 2024), which is included in firebase-tools v13.19.0 (https://github.com/firebase/firebase-tools/releases/tag/v13.19.0).

@dconeybe dconeybe self-assigned this Sep 20, 2024
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 20, 2024

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (dd5a27b) to 10.10% (4c7cbbc) by ?.

    47 individual files with coverage change

    FilenameBase (dd5a27b)Merge (4c7cbbc)Diff
    AnyValue.kt?0.00%?
    AnyValueSerializer.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?33.33%?
    CoroutineExceptionHandler.kt?50.00%?
    DataConnectAppCheck.kt?0.00%?
    DataConnectAuth.kt?0.00%?
    DataConnectCredentialsTokenManager.kt?0.00%?
    DataConnectError.kt?0.00%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?65.82%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectSettings.kt?33.33%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    DateSerializer.kt?0.00%?
    FirebaseDataConnect.kt?21.43%?
    FirebaseDataConnectFactory.kt?29.17%?
    FirebaseDataConnectImpl.kt?34.12%?
    FirebaseDataConnectRegistrar.kt?100.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    Logger.kt?52.17%?
    LogLevel.kt?100.00%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?21.95%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?24.00%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?23.53%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    TimestampSerializer.kt?0.00%?
    Util.kt?6.96%?
    UUIDSerializer.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lxhOLNatx5.html

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Unit Test Results

  40 files    40 suites   1m 22s ⏱️
383 tests 383 ✔️ 0 💤 0
766 runs  766 ✔️ 0 💤 0

Results for commit b1747f5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect:
error: Added class com.google.firebase.dataconnect.AnyValue [AddedClass]
error: Added class com.google.firebase.dataconnect.serializers.AnyValueSerializer [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 20, 2024

Size Report 1

Affected Products

  • base

    TypeBase (dd5a27b)Merge (4c7cbbc)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-dataconnect

    TypeBase (dd5a27b)Merge (4c7cbbc)Diff
    aar?663 kB? (?)
    apk (aggressive)?520 kB? (?)
    apk (release)?11.0 MB? (?)
  • protolite-well-known-types

    TypeBase (dd5a27b)Merge (4c7cbbc)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VTqb3GffOG.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect.querymgr [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe merged commit 146dbec into dataconnect Sep 20, 2024
34 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/AnyValue branch September 20, 2024 20:24
dconeybe added a commit that referenced this pull request Sep 20, 2024
@firebase firebase locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants