Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth deprecated methods removal #1575

Merged
merged 38 commits into from
May 3, 2024
Merged

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Apr 25, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

Remove methods that were deprecated in the 11.0.0 release last year.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 25, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

❌  Integration test FAILED

Requested by @jonsimantov on commit edb9720
Last updated: Thu May 2 19:28 PDT 2024
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Windows] [x64] [openssl]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 25, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 26, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Apr 26, 2024
@github-actions github-actions bot removed the tests: failed This PR's integration tests failed. label Apr 26, 2024
auth/src/include/firebase/auth.h Show resolved Hide resolved
auth/src/include/firebase/auth.h Show resolved Hide resolved
auth/src/include/firebase/auth.h Show resolved Hide resolved
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 26, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 26, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 29, 2024
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 29, 2024
@jonsimantov
Copy link
Contributor Author

Another sanity check to try, run the reference doc generation, and make sure that looks good.

Makes sense - running packaging workflow to generate docs from.

@jonsimantov
Copy link
Contributor Author

Another sanity check to try, run the reference doc generation, and make sure that looks good.

Confirmed that docs generation looks good, merging this.

@jonsimantov jonsimantov enabled auto-merge (squash) May 3, 2024 00:16
@jonsimantov jonsimantov merged commit edb9720 into main May 3, 2024
30 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels May 3, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2024
@firebase firebase locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants