Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemoteConfig info initialization issues #1639

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Sep 6, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

On Android, handle the underlying SDK returning a negative fetch time. On iOS, fix throttled_time initialization issues.

Fixes this Unity issue, since the incorrect values were getting added to TimeSpans, which caused exceptions to be thrown: firebase/firebase-unity-sdk#1058


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Testing locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Sep 6, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

✅  Integration test succeeded!

Requested by @a-maurice on commit 09b7957
Last updated: Fri Sep 6 15:43 PDT 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Sep 6, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 6, 2024
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor nit.

@a-maurice a-maurice enabled auto-merge (squash) September 6, 2024 21:11
@a-maurice a-maurice merged commit 09b7957 into main Sep 6, 2024
30 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Sep 6, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 6, 2024
@a-maurice a-maurice deleted the am-remote_config_info branch October 1, 2024 22:08
@firebase firebase locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants