Skip to content

Commit

Permalink
Fix release script. (#1602)
Browse files Browse the repository at this point in the history
* Fix release script.

Today, release script is broken with error message:

```
node_modules/google-gax/build/src/fallback.d.ts:20:34 - error TS2724: '"google-auth-library"' has no exported member named 'AnyAuthClient'. Did you mean 'AuthClient'?

20 import { GoogleAuth, AuthClient, AnyAuthClient } from 'google-auth-library';
```

It looks like the issue is related to some odd type incompatibility issue in an upstream package (google-gax). Rather than wait for the issue to be resolved, the change here removes command to install firebase-admin which isn't needed to build the release package anyway.

* Revert change to remove --production flag.
  • Loading branch information
taeold authored Aug 30, 2024
1 parent 3a78784 commit a13ca20
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
"docgen:v2:gen": "api-documenter-fire markdown -i docgen/v2 -o docgen/v2/markdown --project functions && npm run docgen:v2:toc",
"docgen:v2": "npm run build && npm run docgen:v2:extract && npm run docgen:v2:gen",
"build:pack": "rm -rf lib && npm install && tsc -p tsconfig.release.json && npm pack",
"build:release": "npm ci --production && npm install --no-save typescript firebase-admin && tsc -p tsconfig.release.json",
"build:release": "npm ci --production && npm install --no-save typescript && tsc -p tsconfig.release.json",
"build": "tsc -p tsconfig.release.json",
"build:watch": "npm run build -- -w",
"format": "npm run format:ts && npm run format:other",
Expand Down

0 comments on commit a13ca20

Please sign in to comment.