Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploying a function with memory: '4GB' leads to getting deployed with the default 256MB #834

Closed
leon opened this issue Dec 22, 2020 · 2 comments · Fixed by #842
Closed

Comments

@leon
Copy link
Contributor

leon commented Dec 22, 2020

Related issues

We have some cpu and memory intensive image resizes in a cloud function.
We have been using the max 2GB in production and everything has worked well.
I now wanted to make it even faster and so I changed to the new 4GB option.

But when I deploy it defaults back to 256MB

[REQUIRED] Version info

node:
node for development: v14.15.2
node set for functions: 12

firebase-functions:
3.13.0

firebase-tools:
9.1.0

firebase-admin:
9.4.2

[REQUIRED] Test case

export const storage = functions
  .region('europe-west1')
  .runWith({
    memory: '4GB',
    timeoutSeconds: 540,
  })
  .storage.bucket('my-special-bucket')
  .object()
  .onFinalize(projectStorageRouter)

[REQUIRED] Steps to reproduce

firebase deploy --only functions:storage

[REQUIRED] Expected behavior

function should deploy with 4GB memory

[REQUIRED] Actual behavior

function deploys with 256MB memory

Were you able to successfully deploy your functions?

yes it deploys as usual but with wrong memory setting

@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

leon pushed a commit to leon/firebase-functions that referenced this issue Jan 8, 2021
The 4GB memory option was not added everywhere.

Fixes firebase#834
@leon
Copy link
Contributor Author

leon commented Jan 10, 2021

When is the next release coming out?
I really need the speed boost this will give my cloud functions, It would be awesome if my pull request could be included in the next release 🚀

joehan added a commit that referenced this issue Jan 13, 2021
* Add support for 4GB memory option

The 4GB memory option was not added everywhere.

Fixes #834

* Added test for 4GB memory option

Co-authored-by: Leon Radley <leon@wec360.se>
Co-authored-by: joehan <joehanley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants