Expose stack on functions.yaml instead of stack.yaml. #1036
Conversation
| @@ -85,7 +85,8 @@ async function startBin( | |||
| env: { | |||
| PATH: process.env.PATH, | |||
| GLCOUD_PROJECT: 'test-project', | |||
| STACK_CONTROL_API_PORT: port, | |||
| PORT: port, | |||
There was a problem hiding this comment.
What's the reason for changing this to a more generic name? Isn't it likely that users might have this var set for other processes.
There was a problem hiding this comment.
The original design used two ports: one for the general API and one for the "control" API. We discovered that Python cannot handle two ports on the same process, so we are consolidating on one port. $PORT is the standard env variable for Cloud Run, so we're using it too.
| @@ -85,7 +85,8 @@ async function startBin( | |||
| env: { | |||
| PATH: process.env.PATH, | |||
| GLCOUD_PROJECT: 'test-project', | |||
| STACK_CONTROL_API_PORT: port, | |||
| PORT: port, | |||
There was a problem hiding this comment.
The original design used two ports: one for the general API and one for the "control" API. We discovered that Python cannot handle two ports on the same process, so we are consolidating on one port. $PORT is the standard env variable for Cloud Run, so we're using it too.
| try { | ||
| const stack = await loadStack(functionsDir); | ||
| res.setHeader('content-type', 'text/yaml'); | ||
| res.send(JSON.stringify(stack)); |
There was a problem hiding this comment.
Lol. I guess JSON is technically YAML.
|
I kaumbakahuma, I appreciate your help and support for this service from file Bass. |
Some contractual changes to how we expose the container contract:
__/functions.yamlinstead of__/stack.yamlin the control apiSTACK_CONTROL_API_PORTtoPORTandFUNCTIONS_CONTROL_API(whose value should equaltrue).