Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Eventfilters to a Record structure #1070

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Change Eventfilters to a Record structure #1070

merged 3 commits into from
Mar 31, 2022

Conversation

colerogers
Copy link
Contributor

Changes eventFilters to match the approved container contract.

@taeold taeold mentioned this pull request Mar 31, 2022
Merged
taeold
taeold requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add unclear changelong entry for this change we can ship a release (we can't ship a release w/ an empty changelog)

src/runtime/manifest.ts Show resolved Hide resolved
@taeold taeold mentioned this pull request Mar 31, 2022
Merged
@colerogers colerogers merged commit 47ac6b8 into master Mar 31, 2022
@colerogers colerogers deleted the colerogers.change-eventfilters branch March 31, 2022 23:53
inlined
inlined reviewed Apr 5, 2022
View reviewed changes
Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d7p d7p mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined left review comments

@taeold taeold taeold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colerogers @inlined @taeold