Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Firestore podspec: avoid adding Firestore headers to sources (#4054)
See #4035: a certain combination of pods can lead to a broken build. The underlying issue is that CocoaPods generate a header map that includes headers from _all_ the pods in a project. A header map maps short file names to full paths and is unable to handle collisions; thus, in a CocoaPods-based build, if one pod contains a header with a common name, and the other pod tries to import a header with the same short name by relying on header maps (without specifying a longer path), the header from one pod may end up getting erroneously picked up by the other pod. In that particular case, `SVGKit` is relying on header maps and trying to import `Document.h`, which, for reasons described above, happens to pick up `document.h` from Firestore. However, since header maps cannot handle collisions in general, this could manifest with other pods as well. The workaround is to avoid adding Firestore header files (except the public ones) to sources. See facebook/react-native#14326, which describes the same problem. Fixes #4035.
- Loading branch information